Project: doctolib-doctolib · Branch: .invalid · Mode: ` · **Model:**claude-haiku-4-5-20251001`
Stats: 1 user messages, 2 tool calls, tools used: Bash.
Conversation
Turn 1 — User
Use gh pr view 238556 --repo doctolib/doctolib to fetch the PR details. Also run gh pr diff 238556 --repo doctolib/doctolib to see the full diff.
Return: 1. PR title and description 2. A concise summary of what the change does 3. List of all changed files
Turn 1 — Assistant
I'll fetch the PR details and diff for you.
Tools used:
Bash:gh pr view 238556 --repo doctolib/doctolib
Tool results:
→ result (ok): title: feat(FHIR-2169): add default document icon to NhrDocumentList category column
state: OPEN
author: nivethayadhavan
labels: ai-augmented, auto_risk_level:high
assignees:
reviewers: doctolib/deployment (Requested), doctolib/fire (Requested)
projects:
milestone:
number: 238556
url: https://github.com/doctolib/doctolib/pull/238556
additions: 65
deletions: 0
auto-merge: disabled
--
Context
The NhrDocumentCategoryCell compone
…(truncated, 1418 more chars)
Now let me get the diff:
Tools used:
Bash:gh pr diff 238556 --repo doctolib/doctolib
Tool results:
→ result (ok): diff --git a/package-lock.json b/package-lock.json index 1f1490ad7a67c..6d8518586b4df 100644 --- a/package-lock.json +++ b/package-lock.json @@ -66104,6 +66104,7 @@ "version": "1.0.0", "license": "Doctolib", "dependencies": { + "@doctolib/design-system-icons": "^2.22.0", "@doctolib/dmp": "^1.0.0", "@doctolib/tpf-national-health-records": "^4.1.1", "@doctolib/tpf-national-health-records-ui": "^10.0.0", diff --git a/packages/@doctolib/national …(truncated, 4130 more chars)
Summary
PR #238556: feat(FHIR-2169): add default document icon to NhrDocumentList category column
What the change does
This PR adds a default document icon (FileRegularIcon) to the NhrDocumentList category column. Previously, the component supported displaying icons via an iconMap parameter, but the columnsFactory.ts wasn't providing one, so categories appeared as text-only. Now every category row displays a file icon to the left of its label.
Changed files
packages/@doctolib/national-health-records/package.json— Added@doctolib/design-system-iconsas an explicit dependency (v2.22.0)packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.ts— AddediconMap: { '*': FileRegularIcon }to thecreateNhrDocumentCategoryColumncallpackages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.test.ts(new file) — Added 2 unit tests verifying the icon map is passed and contains the catch-all key with FileRegularIconpackage-lock.json— Updated lock file with new dependency
All tests pass and pre-commit hooks pass.