Project: doctolib-doctolib · Branch: .invalid · Mode: ` · **Model:**claude-opus-4-7`

Stats: 1 user messages, 34 tool calls, tools used: Bash, Read.

Conversation

Turn 1 — User

You are reviewing PR #241005 in the doctolib/doctolib monorepo (branch FHIR-2195-monolith-add-action-config-to-handle-updating-document-status).

PR Summary

Wires archive/unarchive document status actions into the NHR document list UI. Introduces: - useNhrDocumentStatusActions hook (state machine for the full archive/unarchive flow) - useInvalidateNhrDocuments hook (cache invalidation) - NhrDocumentActionDialog component (thin dialog wrapper) - Updated actionsBuilder.createMoreActionsAction to accept DropdownActionOption[] - Removes healthCareSettings from DocumentStatusUpdateProps (reads from session internally) - Adds status/message/code fields to SearchDocumentsResult

Full diff of all non-lockfile changes

=== packages/@doctolib/national-health-records/src/hooks/useNhrDocumentStatusActions.ts (NEW) ===

import { useCallback, useMemo, useState } from 'react'
import type { NhrDocument } from '@doctolib/tpf-national-health-records'
import type { DropdownActionOption } from '@doctolib/tpf-national-health-records-ui'
import type { Patient } from 'monolith_DEPRECATED/types/doctor/api/Patient'
import i18n from 'monolith_DEPRECATED/services/i18n'
import { isActive, isArchived } from '../variants/dmp/mappers/dmpDocumentHelpers'
import { toNhrPatientInformation } from '../business/mappers/toNhrPatientInformation'
import { useNationalHealthRecords } from './useNationalHealthRecords'
import { useInvalidateNhrDocuments } from './useInvalidateNhrDocuments'
import type { NhrActionModalConfig } from '../types/nhrDocumentActions'

type ModalState = {
  doc: NhrDocument
  config: NhrActionModalConfig
}

const archiveConfig = (): NhrActionModalConfig => ({
  title: i18n.t('national_health_records.document_metadata_actions.dmp.dialogs.archive.title'),
  body: i18n.t('national_health_records.document_metadata_actions.dmp.dialogs.archive.body'),
  confirmLabel: i18n.t('national_health_records.document_metadata_actions.dmp.dialogs.archive.confirm'),
})

const unarchiveConfig = (): NhrActionModalConfig => ({
  title: i18n.t('national_health_records.document_metadata_actions.dmp.dialogs.unarchive.title'),
  body: i18n.t('national_health_records.document_metadata_actions.dmp.dialogs.unarchive.body'),
  confirmLabel: i18n.t('national_health_records.document_metadata_actions.dmp.dialogs.unarchive.confirm'),
})

type UseNhrDocumentStatusActionsResult = {
  options: DropdownActionOption[]
  modalState: ModalState | null
  isLoading: boolean
  error: string | null
  handleConfirm: () => Promise<void>
  handleDismiss: () => void
}

export const useNhrDocumentStatusActions = ({ patient }: { patient: Patient }): UseNhrDocumentStatusActionsResult => {
  const nhrOperations = useNationalHealthRecords({ patient })
  const invalidateNhrDocuments = useInvalidateNhrDocuments(patient)

  const [modalState, setModalState] = useState<ModalState | null>(null)
  const [isLoading, setIsLoading] = useState(false)
  const [error, setError] = useState<string | null>(null)

  const openModal = useCallback(
    (doc: NhrDocument, config: NhrActionModalConfig) => {
      setError(null)
      setModalState({ doc, config })
    },
    // setError and setModalState are stable useState setters — no deps needed

    []
  )

  const options: DropdownActionOption[] = useMemo(
    () => [
      {
        key: 'archive',
        label: i18n.t('national_health_records.document_metadata_actions.dmp.options.archive'),
        isAvailable: isActive,
        onClick: (doc) => openModal(doc, archiveConfig()),
      },
      {
        key: 'unarchive',
        label: i18n.t('national_health_records.document_metadata_actions.dmp.options.unarchive'),
        isAvailable: isArchived,
        onClick: (doc) => openModal(doc, unarchiveConfig()),
      },
    ],
    [openModal]
  )

  const handleConfirm = async () => {
    if (!modalState || !nhrOperations || !patient.ins) return

    setIsLoading(true)
    setError(null)

    try {
      await nhrOperations.upd

…(truncated, 7287 more chars)

Turn 1 — Assistant

I'll review the PR by examining the actual files in the repository to verify the diff context and identify issues.

Tools used:

• Bash: find /Users/USER/workspace/doctolib/doctolib -path '*/worktrees/*' -prune -o -type d -name 'national-health-records' -print 2>/dev/null | head -20

Tool results:

→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records

Tools used:

• Bash: ls /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/

Tool results:

→ result (ok): business hooks index.ts locales mocks variants

The PR's branch isn't checked out locally. Let me look at the current state of files referenced in the PR diff.

Tools used:

• Bash: ls /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/hooks/ /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/busine …(truncated, 110 more chars)

Tool results:

→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/business/: adapters builders constants mappers utils

/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/hooks/: useDmpNhr.test.ts useDmpNhr.ts useGetDocumentsContent.test.ts useGetDocumentsContent.ts useNationalHealthRecords.test.ts useNationalHealthRecords.ts useSearchDocuments.test.ts useSearchDocuments.ts

/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/nation …(truncated, 74 more chars)

Tools used:

• Bash: ls /Users/USER/workspace/doctolib/doctolib/worktrees/doctolib/ 2>/dev/null | head -20

Tool results:

→ result (ok): (Bash completed with no output)

Tools used:

• Bash: git -C /Users/USER/workspace/doctolib/doctolib worktree list 2>&1 | head -30

Tool results:

→ result (ok): /Users/USER/workspace/doctolib/doctolib 0df5cb0202e8 [fhir-2215_wire-dmp-errors-through-dmpnhradapter] /Users/USER/workspace/doctolib/doctolib/.claude/worktrees/crazy-volhard d2d21781dba4 [claude/crazy-volhard] /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2089 9c01fcf036d7 (detached HEAD) /Users/USER/workspace/doctolib/worktrees/doctolib/FHIR-2091-nhr-document-li …(truncated, 1099 more chars)

Tools used:

• Bash: gh pr view 241005 --json headRefName,baseRefName,headRepository 2>&1 | head -20

Tool results:

→ result (ok): {"baseRefName":"master","headRefName":"FHIR-2195-monolith-add-action-config-to-handle-updating-document-status","headRepository":{"id":"MDEwOlJlcG9zaXRvcnkxNDAyMjQyMQ==","name":"doctolib","nameWithOwner":"doctolib/doctolib"}}

Tools used:

• Bash: gh pr diff 241005 --patch 2>&1 | head -500

Tool results:

→ result (ok): From 6b249fe82efec360cf5bb5a10dc6740b3e1ff166 Mon Sep 17 00:00:00 2001 From: Sushan <<REDACTED>> Date: Mon, 27 Apr 2026 15:08:02 +0200 Subject: [PATCH] FHIR-2195: Add config for more actions and update doc status

config/locales/en_tmp.yml | 23 + config/locales/key.yml | 20 + package-lock.json | 3542 ++--------------- package.json | 2 +- .../@doctolib/dmp/src/business/DmpApi.te …(truncated, 23326 more chars)

Let me get the relevant code parts of the diff (skip lockfile):

Tools used:

• Bash: gh pr diff 241005 --patch 2>&1 | grep -v "^diff --git a/package-lock" | awk 'BEGIN{skip=0} /^diff --git/{ if($0 ~ /package-lock\.json/) skip=1; else skip=0 } !skip{print}' | sed -n '/^diff --git a\/pa …(truncated, 41 more chars)

Tool results:

→ result (ok): 844 /tmp/pr_241005_diff.patch

I'll proceed without using task tools as this is a focused review task. Let me read the full diff.

Tools used:

• Read: /tmp/pr_241005_diff.patch

Tool results:

→ result (ok): 1 diff --git a/packages/@doctolib/dmp/src/business/DmpApi.test.ts b/packages/@doctolib/dmp/src/business/DmpApi.test.ts 2 index 781a616f50228..2b146a28faf65 100644 3 --- a/packages/@doctolib/dmp/src/business/DmpApi.test.ts 4 +++ b/packages/@doctolib/dmp/src/business/DmpApi.test.ts 5 @@ -1590,13 +1590,13 @@ describe('DmpApi', () => { 6 it('should call updateDocumentStatusCommand with session and props', async () => { 7 getCachedDmpSessionMocked.mockResolvedValue({ sessionId: 'session-a …(truncated, 40796 more chars)

Now I have all the diff. Let me check a few critical things: existing types and adapter behavior to understand impact, and the propertyName payload.

Tools used:

• Bash: grep -rn "updateDocumentMetadata" /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/ 2>&1 | head -20

Tool results:

→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.ts:213: async updateDocumentMetadata(props: NhrDocumentMetadataUpdateProps): Promise<NhrDocumentMetadataUpdateResult> { /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.test.ts:567: describe('updateDocumentMetadata', () => { /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/s …(truncated, 2587 more chars)

Tools used:

• Read: /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.ts (200–270)

Tool results:

→ result (ok): 200 const result = await this.dmpApi.getDocumentsContentByUniqueId({ 201 ins: toEnvIns(patient.nationalHealthIdentifier), 202 uniqueIds: params.ids, 203 getCdaContent: true, 204 getAuthors: true, 205 }) 206 return result.map((doc) => { 207 const typeCode = doc.cdaContent?.code?._code 208 const facet = findFacetForCDAType(typeCode, this.documentCategorizationFacets) 209 return toNhrDocumentContentResult(doc, facet) 210 }) 211 } 212 213 …(truncated, 2231 more chars)

Important — when the adapter's updateDocumentMetadata returns a 'partial success' or 'error' status, the hook treats it as a SUCCESS because the promise resolves (not rejected). Let me confirm.

Tools used:

• Read: /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.ts (258–288)

Tool results:

→ result (ok): 258 } 259 260 private buildUpdateResult(payloadResults: NhrDocumentMetadataUpdatePayloadResult[]): NhrDocumentMetadataUpdateResult { 261 const hasError = payloadResults.some((r) => r.status === 'error') 262 const hasSuccess = payloadResults.some((r) => r.status === 'success') 263 264 let status: NhrResultStatus 265 266 if (hasError && hasSuccess) { 267 status = 'partial success' 268 } else if (hasError) { 269 status = 'error' 270 } else { 271 stat …(truncated, 111 more chars)

Confirmed — this is a real bug: handleConfirm only treats thrown exceptions as errors but the adapter wraps errors in a status: 'error' result and resolves normally. Now let me check NhrDocument to ensure uuid propagation:

Tools used:

• Bash: grep -rn "interface NhrDocument\|type NhrDocument\b" /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/ /Users/USER/workspace/doctolib/doctolib/node_modu …(truncated, 70 more chars)

Tool results:

→ result (ok): /Users/USER/workspace/doctolib/doctolib/node_modules/@doctolib/tpf-national-health-records/dist/business/types/document.d.ts:18:export type NhrDocument = {

Tools used:

• Read: /Users/USER/workspace/doctolib/doctolib/node_modules/@doctolib/tpf-national-health-records/dist/business/types/document.d.ts

Tool results:

→ result (ok): 1 import type { NhrDocumentAuthor } from '#business/types/participant'; 2 /* The services/procedures this document is associated with / 3 export type NhrServiceInformation = { 4 startDate?: string; 5 endDate?: string; 6 }; 7 export type NhrDocumentClassification = { 8 codes: Code[]; 9 }; 10 export type Code = { 11 system: string; 12 code: string; 13 }; 14 export type DateRange = { 15 upperLimit?: string; 16 lowerLimit?: string; 17 }; 18 export type NhrDocument = { 1 …(truncated, 535 more chars)

NhrDocument does not expose uuid. The hook only sends id and propertyName: 'status'. The adapter calls uuid: uuid ?? ''. Let me check whether DMP updateDocumentStatus requires a real uuid (not empty):

Tools used:

• Read: /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/dmp/src/business/DmpApi.ts (335–395)

Tool results:

→ result (ok): 335 if (!cachedSession) { 336 throw new Error('No DMP session found') 337 } 338 339 const { sessionId } = cachedSession 340 const response = await getDocumentsContent({ sessionId, ...props }) 341 return response.Documents.map(this.toDocumentContent) 342 } 343 344 async updateDocumentStatus(props: DocumentStatusUpdateProps): Promise<void> { 345 const { ins, documentUniqueId: uniqueId, uuid, healthCareSettings, getTransactionFrames } = props 346 347 if (thi …(truncated, 1345 more chars)

Tools used:

• Bash: grep -rn "buildUpdateDocumentStatusPayload\|uuid" /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/dmp/src/business/*.ts 2>&1 | grep -i "payload\|uuid" | head -20

Tool results:

→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/dmp/src/business/DmpApi.ts:23: buildUpdateDocumentStatusPayload, /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/dmp/src/business/DmpApi.ts:345: const { ins, documentUniqueId: uniqueId, uuid, healthCareSettings, getTransactionFrames } = props /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/dmp/src/business/DmpApi.ts:348: const payload = buildUpdateDocumentStatusPayload({ /Users/USER/workspace/doctolib/docto …(truncated, 2216 more chars)

Tools used:

• Bash: grep -rn "buildUpdateDocumentStatusPayload" /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/dmp/src/ 2>&1 | head -5

Tool results:

→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/dmp/src/index.ts:71: buildUpdateDocumentStatusPayload, /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/dmp/src/business/FrDmpCommunication.ts:58: buildUpdateDocumentStatusPayload, /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/dmp/src/business/FrDmpCommunication.ts:419: ...buildUpdateDocumentStatusPayload({ ins, uniqueId, uuid, healthCareSettings, getTransactionFrames }), /Users/USER/workspace/doctolib/doctoli …(truncated, 241 more chars)

Tools used:

• Read: /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/dmp/src/business/frDmpPayloadBuilders.ts (275–315)

Tool results:

→ result (ok): 275 i_getDataEnterer: getDataEnterer ? 1 : 0, 276 i_getParticipants: getParticipants ? 1 : 0, 277 i_getAuthenticators: getAuthenticators ? 1 : 0, 278 i_getDocumentContent: getDocumentContent ? 1 : 0, 279 i_getTransactionFrames: getTransactionFrames ? 1 : 0, 280 }) 281 282 export const buildUpdateDocumentStatusPayload = ({ 283 ins, 284 uniqueId, 285 uuid, 286 healthCareSettings, 287 getTransactionFrames, 288 }: Omit<UpdateDocumentStatusByUniqueIdParams, 'sessionId'>): Without …(truncated, 962 more chars)

Confirmed: the DMP payload requires s_documentUuid (passed from uuid), and the new hook does NOT pass uuid. The adapter passes uuid: uuid ?? '' which sends an empty string. The DMP service will likely fail or behave unexpectedly. Let me also check the Patient type for ins:

Tools used:

• Bash: find /Users/USER/workspace/doctolib/doctolib/app -path "*types/doctor/api/Patient*" 2>/dev/null | head -3

Tool results:

→ result (ok): /Users/USER/workspace/doctolib/doctolib/app/assets/javascripts/types/doctor/api/PatientRegularDoctor.ts /Users/USER/workspace/doctolib/doctolib/app/assets/javascripts/types/doctor/api/Patient.ts

Tools used:

• Bash: grep -n "^\s*ins\b\|ins?:\|ins:" /Users/USER/workspace/doctolib/doctolib/app/assets/javascripts/types/doctor/api/Patient.ts 2>&1 | head -10

Tool results:

→ result (ok): 144: ins?: string | null

Good — patient.ins is string | null | undefined. Now let me check toNhrPatientInformation to verify input type assumptions:

Tools used:

• Bash: find /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src -name "toNhrPatientInformation*" 2>&1 | head -5

Tool results:

→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/business/mappers/toNhrPatientInformation.ts

Tools used:

• Read: /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/business/mappers/toNhrPatientInformation.ts

Tool results:

→ result (ok): 1 import type { NhrPatientInformation } from '@doctolib/tpf-national-health-records' 2
3 export function toNhrPatientInformation(ins: string): NhrPatientInformation { 4 return { 5 nationalHealthIdentifier: ins, 6 } 7 } 8

Tools used:

• Bash: grep -rn "frDmpWorkflow" /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/dmp/src/types/*.ts 2>&1 | head -5

Tool results:

→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/dmp/src/types/DmpApi.ts:118: frDmpWorkflow: DmpWorkflow

Tools used:

• Read: /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/dmp/src/types/DmpApi.ts (100–195)

Tool results:

→ result (ok): 100 // Parsed s_cdaContentInBase64 101 cdaContent?: ClinicalDocument 102 cdaContentInBase64?: string 103 } 104 105 export interface DmpApi { 106 share: (props: ShareProps) => Promise<void> 107 unshare: (props: UnshareProps) => Promise<void> 108 search: (props: SearchProps) => Promise<SearchResult> 109 getPatientConsent: () => Promise<PatientConsent> 110 updatePatientConsent: (consent: PatientConsentUpdate) => Promise<boolean> 111 getDocumentsContentByUniqueId: (props: GetDocum …(truncated, 2635 more chars)

Wait — the DMP DocumentStatusUpdateProps still contains healthCareSettings: string (line 192). But in the diff it's removed (line 81). Let me re-read the actual current file vs the patch. The patch shows line 81 removed but the current state still has it. The branch isn't checked out so the file shows current master. So the diff IS removing healthCareSettings: string from the type. Good.

But I need to check: the adapter's updateDocumentMetadata still references props.additionalInfo.healthcareSettings in current master. The PR diff modifies that to remove it. OK consistent.

Let me check additionalInfo type for updateDocumentMetadata to see if removing it from caller still type-checks (since adapter still reads it):

Tools used:

• Bash: grep -rn "NhrDocumentMetadataUpdateProps\|additionalInfo" /Users/USER/workspace/doctolib/doctolib/node_modules/@doctolib/tpf-national-health-records/dist/ 2>&1 | head -10

Tool results:

→ result (ok): /Users/USER/workspace/doctolib/doctolib/node_modules/@doctolib/tpf-national-health-records/dist/index.d.ts:2:export type { NhrResult, NhrResultStatus, NhrDocumentSearchParams, NhrDocumentSearchProps, NhrDocumentSearchResult, NhrGetDocumentsContentParams, NhrGetDocumentsContentProps, NhrDocumentContentResult, NhrDocumentMetadataUpdatePayload, NhrDocumentMetadataUpdateParams, NhrDocumentMetadataUpdateAdditionalInfo, NhrDocumentMetadataUpdateProps, NhrDocumentMetadataUpdatePayloadResult, NhrDocumen …(truncated, 2700 more chars)

Tools used:

• Read: /Users/USER/workspace/doctolib/doctolib/node_modules/@doctolib/tpf-national-health-records/dist/business/types/api.d.ts

Tool results:

→ result (ok): 1 import type { DateRange, NhrDocument, NhrDocumentFile } from '#business/types/document'; 2 import type { NhrPatientInformation } from '#business/types/participant'; 3 export type NhrResultStatus = 'success' | 'skipped' | 'error' | 'partial success'; 4 export type NhrResult = { 5 status: NhrResultStatus; 6 message?: string; 7 code?: string; 8 }; 9 export type NhrDocumentSearchParams = { 10 formats?: string[]; 11 categories?: string[]; 12 status?: string; 13 serviceSt …(truncated, 1993 more chars)

Critical finding: NhrDocumentMetadataUpdateProps.additionalInfo is required in the current <REDACTED>. The new hook's call:

nhrOperations.updateDocumentMetadata({
  patient: ...,
  params: { ... },
})

omits additionalInfo entirely → this is a TypeScript error with the currently installed version. The PR bumps @doctolib/tpf-national-health-records to ^7.0.0 but the lockfile still resolves the version installed in node_modules (could be 6.x). Let me check:

Tools used:

• Bash: cat /Users/USER/workspace/doctolib/doctolib/node_modules/@doctolib/tpf-national-health-records/package.json 2>&1 | grep '"version"' | head -3

Tool results:

→ result (ok): "version": "6.2.0",

The PR bumps the dep range to ^7.0.0 but the lockfile must reflect the install. The TypeScript surface in 7.0.0 presumably makes additionalInfo optional. This is a coordinated breaking change in the upstream package — likely fine but worth noting.

Now let me check DropdownActionOption from tpf-ui for whether key and isAvailable are correctly named:

Tools used:

• Bash: grep -rn "DropdownActionOption" /Users/USER/workspace/doctolib/doctolib/node_modules/@doctolib/tpf-national-health-records-ui/dist/ 2>&1 | head -10

Tool results:

→ result (ok): /Users/USER/workspace/doctolib/doctolib/node_modules/@doctolib/tpf-national-health-records-ui/dist/types.d.ts:63:export type DropdownActionOption = { /Users/USER/workspace/doctolib/doctolib/node_modules/@doctolib/tpf-national-health-records-ui/dist/types.d.ts:97: options: DropdownActionOption[]; /Users/USER/workspace/doctolib/doctolib/node_modules/@doctolib/tpf-national-health-records-ui/dist/index.d.ts:3:export type { ActionConfig, DropdownActionOption, BasicActionConfig, DropdownActionConfi …(truncated, 752 more chars)

Tools used:

• Read: /Users/USER/workspace/doctolib/doctolib/node_modules/@doctolib/tpf-national-health-records-ui/dist/types.d.ts (55–105)

Tool results:

→ result (ok): 55 export type NhrVisibilityEntry = { 56 label: string; 57 isVisible: boolean; 58 variant?: 'warning' | 'info'; 59 }; 60 / Factory that produces actions for a given document selection callback */ 61 export type ActionsFactory = (onDocumentSelected: (id: string) => void) => ActionConfig[]; 62 / One item in a dropdown menu opened by a DropdownActionConfig / 63 export type DropdownActionOption = { 64 / Unique key for React reconciliation / 65 key: string; 66 /** Visi …(truncated, 1617 more chars)

Critical finding: In the currently installed @doctolib/<REDACTED>, DropdownActionOption.onClick is () => void | Promise<void> (no doc argument), and there's no isAvailable field. The hook uses:

{
  key: 'archive',
  label: ...,
  isAvailable: isActive,           // <-- doesn't exist on v14
  onClick: (doc) => openModal(doc, archiveConfig()),  // <-- but onClick takes no args on v14
}

The PR bumps to ^16.0.0 so a new shape is expected. This is consistent only if v16 has the new fields. Cannot verify without the new package source. I'll flag this only if obviously inconsistent — it's a coordinated upstream bump and tests would catch it. Mark as a question rather than an issue.

Let me check the i18n key consistency:

Tools used:

• Bash: grep -n "common.actions.cancel" /Users/USER/workspace/doctolib/doctolib/config/locales/en_tmp.yml /Users/USER/workspace/doctolib/doctolib/config/locales/key.yml /Users/USER/workspace/do …(truncated, 53 more chars)

Tool results:

→ result (ok): /Users/USER/workspace/doctolib/doctolib/config/locales/key.yml:18325: cancel: common.actions.cancel /Users/USER/workspace/doctolib/doctolib/config/locales/key.yml:18326: cancel_changes: common.actions.cancel_changes /Users/USER/workspace/doctolib/doctolib/config/locales/key.yml:18327: cancel_confirmation: common.actions.cancel_confirmation

Good. Now let me verify behavior of 'partial success' adapter status as truly an issue and consider ESLint comment rule:

The hook never inspects result.status. If 1-of-N payloads fail, 'partial success' resolves and setModalState(null) runs — user sees success despite failure. With a single payload (current usage), partial-success is impossible since either it errors or succeeds for that one. But the status: 'error' case (no individual exception thrown — adapter catches and returns) DOES hit single-payload calls and would silently appear successful.

Let me check useNationalHealthRecords return type:

Tools used:

• Read: /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/hooks/useNationalHealthRecords.ts

Tool results:

→ result (ok): 1 import type { 2 NhrDocumentSearchProps, 3 NhrDocumentSearchResult, 4 NhrGetDocumentsContentProps, 5 NhrDocumentContentResult, 6 NhrDocumentMetadataUpdateProps, 7 NhrDocumentMetadataUpdateResult, 8 } from '@doctolib/tpf-national-health-records' 9 import { useProductLineVariation, ProductLineKey } from '@doctolib/variation_management' 10 import type { Patient } from 'monolith_DEPRECATED/types/doctor/api/Patient' 11 import { useDmpNhr } from './useDmpNhr' 12
13 export type UseNhrOper …(truncated, 966 more chars)

Key — useNationalHealthRecords is typed as returning UseNhrOperations but actually returns null for non-French product lines (per the variant shape). The hook does if (!nhrOperations || ...) — works at runtime but the type assertion in the test (null as never) confirms this is a typing fudge, but pre-existing. Still it justifies the runtime null-check in the new hook.

Now let me look at what the existing hooks do for error handling/state patterns to compare style:

Tools used:

• Read: /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/hooks/useGetDocumentsContent.ts

Tool results:

→ result (ok): 1 import { useState, useCallback } from 'react' 2 import type { Patient } from 'monolith_DEPRECATED/types/doctor/api/Patient' 3 import type { NhrDocumentContentResult } from '@doctolib/tpf-national-health-records' 4 import type { GetDocumentsContent } from '../variants/types' 5 import { useNationalHealthRecords } from './useNationalHealthRecords' 6
7 export const useGetDocumentsContent = ({ 8 patient, 9 }: { 10 patient: Patient 11 }): { getDocumentsContent: GetDocumentsContent; documentsCon …(truncated, 1064 more chars)

I have everything I need. Let me also check one thing — the handleConfirm and handleDismiss not being wrapped in useCallback in the new hook. The nhrActions useMemo in PatientCard.tsx depends on options which is memoized, but the options array reference returned via the hook depends on openModal which is useCallback([]). So options is stable. That's fine.

But in PatientCard, nhrActions's memo deps [getDocumentsContent, options]. Both stable. OK.

Now let me check key exports — there's a conflicting export name with useNhrDocumentListVariant:

Tools used:

• Read: /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/index.ts

Tool results:

→ result (ok): 1 export { useNationalHealthRecords, type UseNhrOperations } from './hooks/useNationalHealthRecords' 2 export { useDmpNhr } from './hooks/useDmpNhr' 3 export { useNhrDocumentListVariant } from './variants/useNhrDocumentListVariant' 4 export type { DocumentSearchOptions, NhrDocumentListVariant } from './variants/types' 5 export { actionsBuilder, type NhrActionsBuilder } from './business/builders/actionsBuilder' 6 export { useGetDocumentsContent } from './hooks/useGetDocumentsContent' 7

Let me also check whether NhrDocument from tpf is already re-exported by the package (since the diff adds a re-export):

Tools used:

• Bash: grep -rn "export.*NhrDocument\b" /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/ 2>&1 | head -10

Tool results:

→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/mocks/filterMockedDocuments.ts:10:export function filterMockedDocuments(docs: NhrDocument[], filters: ServerFilters): NhrDocument[] { /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/mocks/generateNhrDocuments.ts:80:export function generateNhrDocuments(options?: GenerateNhrDocumentsOptions): NhrDocument[] { /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/nationa …(truncated, 1642 more chars)

Good — re-exports of NhrDocument and DropdownActionOption are first-time. Fine.

I have enough context to deliver the review. Let me also confirm the handleConfirm not being a useCallback creates an issue. The hook returns handleConfirm and handleDismiss as fresh references on each render. These are used in PatientCard only as props to <NhrDocumentActionDialog> (a non-memoized component). Not a perf issue.

Code Review: PR #241005

Files reviewed

• /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/dmp/src/business/DmpApi.ts
• /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/dmp/src/types/DmpApi.ts
• /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.ts
• /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/business/builders/actionsBuilder.ts
• /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/components/NhrDocumentActionDialog.tsx
• /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/hooks/useInvalidateNhrDocuments.ts
• /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/hooks/useNhrDocumentStatusActions.ts
• /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/hooks/useSearchDocuments.ts
• /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/types.ts
• /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/mappers/dmpDocumentHelpers.ts
• /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/shared_patient_file_and_appointment_page_components/src/desktop/PatientCard/PatientCard.tsx
• New index.ts re-exports, nhrDocumentActions.ts types, locales, related tests

Critical (90-100)

1. handleConfirm treats adapter-level error/partial-success as success (confidence 95)

File: packages/@doctolib/national-health-records/src/hooks/useNhrDocumentStatusActions.ts, lines ~84-99 (handleConfirm)

DmpNhrAdapter.updateDocumentMetadata catches DMP errors per payload and returns a resolved promise with status: 'error' (or 'partial success'). It only throws when patient.nationalHealthIdentifier is missing. The hook treats every resolved promise as success: it closes the modal and triggers cache invalidation, so a failed archive looks like it succeeded to the user.

Confirmed by reading DmpNhrAdapter.ts lines 222-275 (each payload error is caught and folded into payloadResults; buildUpdateResult returns { status: 'error' | 'partial success' | 'success', result: { payloads } }).

Fix: inspect the awaited result:

const result = await nhrOperations.updateDocumentMetadata({...})
if (result.status === 'error' || result.status === 'partial success') {
  setError(i18n.t('national_health_records.document_metadata_actions.dmp.errors.action_failed'))
  return
}
setModalState(null)
await invalidateNhrDocuments()

The existing test 'shows error and keeps dialog open on failure' only covers a thrown rejection, so this path is uncovered. Add a test where updateDocumentMetadata resolves with status: 'error'.

2. uuid is dropped on the way to DMP updateDocumentStatus (confidence 92)

Files: - packages/@doctolib/national-health-records/src/hooks/useNhrDocumentStatusActions.ts, line ~90 (payload built without uuid) - packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.ts, line ~231 (uuid: uuid ?? '') - Downstream: packages/@doctolib/dmp/src/business/frDmpPayloadBuilders.ts, line 291 (s_documentUuid: uuid)

The hook calls updateDocumentMetadata with payloads: [{ id: modalState.doc.id, propertyName: 'status' }] — no uuid. The adapter falls back to the empty string and sends s_documentUuid: '' to the DMP teleservice. Since the FR-DMP UpdateDocumentStatus action keys the document by (uniqueId, uuid), this will either be rejected by the teleservice or update a wrong record.

Two possible roots: - NhrDocument (from tpf-national-health-records) does not expose uuid today (verified in node_modules/@doctolib/tpf-national-health-records/dist/business/types/document.d.ts). Either the v7 bump exposes it, or the source list must also carry uuid so it can flow through. - The adapter should not silently substitute '' for a missing required field — better to skip with 'skipped' and a clear message.

Fix: plumb uuid from the document through the payload, or short-circuit when uuid is missing instead of sending an empty string. Add a regression test.

3. Removing healthCareSettings from DocumentStatusUpdateProps is a breaking change for external consumers of @doctolib/dmp (confidence 86)

File: packages/@doctolib/dmp/src/types/DmpApi.ts (line 192 in current master).

DocumentStatusUpdateProps is part of the public type surface of @doctolib/dmp. The PR makes the field disappear and reads it from this.props.frDmpWorkflow.healthcareSettings inside the impl. Any other caller that still passes healthCareSettings will now get a TypeScript error, and any path where frDmpWorkflow.healthcareSettings is undefined at the time updateDocumentStatus is called will silently send s_healthCareSettings: undefined to the teleservice.

Action items: - Confirm there is no other caller of updateDocumentStatus (a quick monorepo grep would be reassuring) and call out the API change in the PR description / package changelog. - Either narrow the frDmpWorkflow.healthcareSettings type (so TS guarantees a string at this point) or guard at the start of updateDocumentStatus and throw early if it is missing.

Important (80-89)

4. useInvalidateNhrDocuments builds query key from a possibly-null patient.ins (confidence 84)

File: packages/@doctolib/national-health-records/src/hooks/useInvalidateNhrDocuments.ts

Patient.ins is string | null | undefined (verified in app/assets/javascripts/types/doctor/api/Patient.ts:144). useSearchDocuments keys its cache as ['dmp-documents', ins, appliedFilters] only after a non-null guard. The new hook unconditionally invalidates ['dmp-documents', patient.ins] — when ins is null/undefined this won't match anything cached. It happens that handleConfirm already early-returns on !patient.ins, so today this is dead-but-harmless code, but the hook in isolation has a contract bug.

Fix: either guard inside the hook, type the parameter as { patient: Patient & { ins: string } }, or accept ins: string directly so the call site has to prove it's set.

5. ESLint disable comment in CLAUDE.md global rules — comment-only directive in callback deps (confidence 80)

File: packages/@doctolib/national-health-records/src/hooks/useNhrDocumentStatusActions.ts lines 36-39

The dep array of useCallback(openModal, []) has an inline justification:

// setError and setModalState are stable useState setters — no deps needed

This is fine and not an eslint-disable. However, the user's global rule disallows eslint-disable-next-line and similar suppressions; if the project's react-hooks/exhaustive-deps rule lints this empty array, an actual disable directive may sneak in later. Not a blocker — just verify npm run lint is clean on this file.

6. Adapter still typed against old TPF shape; only works after the upstream bump (confidence 80)

File: packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.ts lines 218-220

Currently installed @doctolib/<REDACTED> makes additionalInfo required on NhrDocumentMetadataUpdateProps (verified in node_modules/.../api.d.ts:55-58). The diff still references props.additionalInfo only via const { healthcareSettings } = props.additionalInfo (removed). The hook's call omits additionalInfo entirely. This …(truncated, 2643 more chars)