Project: treatment-plan · Branch: main · Mode: ` · **Model:**claude-sonnet-4-6`
Stats: 1 user messages, 43 tool calls, tools used: Bash, Read.
Conversation
Turn 1 — User
Review the frontend architecture of PR https://github.com/doctolib/doctolib/pull/240556 (branch fhir-2216_fix-nhr-date-columns-and-document-type).
This PR modifies TypeScript files in the monolith's packages/@doctolib/national-health-records/ package:
- src/business/adapters/DmpNhrAdapter.ts: Added parseHl7DateToIso helper function and dual-code classification
- src/variants/dmp/mappers/dmpDocumentHelpers.ts: Updated exports — getTypeCode, getProcedureDate, getShareDate return types changed; split a shared constant
- src/mocks/nhrMockedDocuments.ts: Mock data updated
Key changes to evaluate:
1. parseHl7DateToIso is a private function within the adapter — is it correctly scoped?
2. getProcedureDate/getShareDate now return string | undefined instead of string. Callers in columnsFactory.tsx pass these to createNhrProcedureDateColumn/createNhrShareDateColumn which accept (doc) => string | null | undefined — is the type change compatible?
3. CLASS_CODE_SYSTEM / TYPE_CODE_SYSTEM split from DMP_SYSTEM — both are module-private constants. Is this the right pattern?
4. The comments added in dmpDocumentHelpers.ts — are they necessary and correct?
Report actionable architecture issues only.
Turn 1 — Assistant
I'll start by examining the PR diff and the relevant source files to conduct a thorough architecture review.
Tools used:
Bash:cd /Users/USER/workspace/doctolib && git worktree list 2>/dev/null | grep -i fhir-2216 || echo "No worktree found"
Tools used:
Bash:ls /Users/USER/workspace/doctolib/worktrees/doctolib/ 2>/dev/null || echo "No worktrees directory found"
Tool results:
→ result (ok): No worktree found
Tool results:
→ result (ok): fhir-2089 FHIR-2091-nhr-document-list-pagination FHIR-2166-fix-nhr-mock-status-visibility fhir-2169 fhir-2181 fhir-2189_class-code-label-map fhir-2190_improve-filter-panel-ui fhir-2209_fix-patient-ins-env-transformation fhir-2216_fix-nhr-date-columns-and-document-type
The worktree exists. Let me read the relevant files from it.
Tools used:
Bash:cd /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type && git log --oneline -5
Tools used:
Bash:cd /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type && git diff origin/master...HEAD --name-only -- 'packages/@doctolib/national-health-records/* …(truncated, 2 more chars)
Tool results:
→ result (ok): 7202a79098b2 feat(FHIR-2216): fix NHR date columns and document type rendering with real DMP data e9e5b85518d1 refactor(PASTA-4418): Move Profile events into ProfileManagement engine (#240444) 0757fd288b2a refactor(PASTA-2575): deprecate speciality/agendas associations in Calendar and Speciality [3/n] (#240379) 361db04def8a feat(CAI-2444): remove feature switch improved_preference_handling (#240324) d716bf6fc76b feat(BOSS-4230): add profession search debug page (#240217)
Tool results:
→ result (ok): packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.test.ts packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.ts packages/@doctolib/national-health-records/src/mocks/nhrMockedDocuments.ts packages/@doctolib/national-health-records/src/variants/dmp/mappers/dmpDocumentHelpers.test.ts packages/@doctolib/national-health-records/src/variants/dmp/mappers/dmpDocumentHelpers.ts
Tools used:
Bash:cd /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type && git diff origin/master...HEAD -- 'packages/@doctolib/national-health-records/src/business/ …(truncated, 195 more chars)
Tool results:
→ result (ok): diff --git a/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.ts b/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.ts index caf8a204d53d..ad72b89d2fd3 100644 --- a/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.ts +++ b/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.ts @@ -85,25 +85,48 @@ function toAuthor(author: DmpAuthor): NhrDocumentAuthor { } }
+// DMP API retur …(truncated, 22431 more chars)
Now let me read the callers of getProcedureDate and getShareDate, and the column factory to assess the type compatibility question.
Tools used:
Bash:find /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src -name "columnsFactory*" -o -name "*.columns. …(truncated, 14 more chars)
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.test.ts /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.tsx
Tools used:
Bash:grep -rn "getProcedureDate\|getShareDate\|createNhrProcedureDateColumn\|createNhrShareDateColumn" /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-typ …(truncated, 61 more chars)
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.test.ts:15: getProcedureDate: jest.fn(), /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.test.ts:16: getShareDate: jest.fn(), /Users/USER/workspace/doctolib/worktrees/doctolib/fh …(truncated, 4896 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.tsx
Tool results:
→ result (ok): 1 import type { ColumnConfig } from '@doctolib/tpf-national-health-records-ui'
2 import {
3 createNhrDocumentCategoryColumn,
4 createNhrDocumentNameColumn,
5 createNhrProcedureDateColumn,
6 createNhrShareDateColumn,
7 createNhrSharedByColumn,
8 createNhrStatusColumn,
9 createNhrVisibilityColumn,
10 } from '@doctolib/tpf-national-health-records-ui'
11 import { DOCUMENT_STATUS } from '@doctolib/dmp'
12 import type { DesignSystemIconComponent } from '@doctolib/design-system-icons'
13
…(truncated, 2473 more chars)
Tools used:
Bash:grep -rn "createNhrProcedureDateColumn\|createNhrShareDateColumn" /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/ --include="*.ts" --i …(truncated, 29 more chars)
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.test.ts /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.tsx
Tools used:
Bash:find /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/ -path "*/tpf-national-health-records-ui/src*" -name "*.ts" -o -path "*/tpf-nation …(truncated, 137 more chars)
Tools used:
Bash:find /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/ -name "createNhrProcedureDateColumn*" -o -name "createNhrShareDateColumn*" 2>/dev …(truncated, 5 more chars)
Tool results:
→ result (ok): (Bash completed with no output)
Tool results:
→ result (ok): (Bash completed with no output)
Tools used:
Bash:find /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/ -name "*.ts" -o -name "*.tsx" 2>/dev/null | xargs grep -l "createNhrProcedureDate …(truncated, 55 more chars)
Tools used:
Bash:find /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/ -name "*.ts" -o -name "*.tsx" 2>/dev/null | head -5 && ls /Users/USER/worksp …(truncated, 102 more chars)
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/doctor_appointment_booking_actions/index.ts /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/secure_messaging_inbox/index.ts /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/e_rezept/index.ts /Users/USER/workspace/doctolib/worktrees/doctolib/fh …(truncated, 378 more chars)
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.test.ts /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.tsx
Tools used:
Bash:ls /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/ | grep -i "national-health\|nhr\|tpf"
Tool results:
→ result (ok): national-health-records
Tools used:
Bash:find /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/node_modules/@doctolib -maxdepth 1 -type d 2>/de …(truncated, 17 more chars)
Tool results:
→ result (ok): (Bash completed with no output)
Tools used:
Bash:find /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type -name "tpf-national-health-records-ui" -type d 2>/dev/null | head -5
Tool results:
→ result (ok): (Bash completed with no output)
Tools used:
Bash:find /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type -path "*/node_modules/@doctolib/tpf-national-health-records-ui" -maxdepth 7 -type d 2>/dev/ …(truncated, 14 more chars)
Tool results:
→ result (ok): (Bash completed with no output)
Tools used:
Bash:find /Users/USER/workspace/doctolib -path "*/tpf-national-health-records-ui/src" -type d 2>/dev/null | head -5
Tool results:
→ result (ok): Command running in background with ID: b8cg9vupu. Output is being written to: /private/tmp/claude-501/-Users-clertonra-workspace-doctolib-treatment-plan/4a60c61a-52a8-4582-9de5-258d84f5e6ef/tasks/b8cg9vupu.output
Tools used:
Bash:cat /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/package.json | grep -A5 "tpf-national-health-reco …(truncated, 36 more chars)
Tool results:
→ result (ok): "@doctolib/tpf-national-health-records": "^6.1.0", "@doctolib/tpf-national-health-records-ui": "^14.1.0", "@doctolib/variation_management": "^1.0.0", "@tanstack/react-query-v5": "npm:@tanstack/react-query@^5.51.15", "react": "^18.3.1", "react-dom": "^18.3.1" }
Tools used:
Bash:find /Users/USER/workspace/doctolib -name "package.json" -path "*tpf-national-health-records-ui*" ! -path "*/node_modules/*" 2>/dev/null | head -5
Tool results:
→ result (ok): Command running in background with ID: bm0trxstk. Output is being written to: /private/tmp/claude-501/-Users-clertonra-workspace-doctolib-treatment-plan/4a60c61a-52a8-4582-9de5-258d84f5e6ef/tasks/bm0trxstk.output
Tools used:
Bash:ls /Users/USER/workspace/doctolib/upfront/packages/ 2>/dev/null | grep -i "national-health\|nhr\|tpf" | head -10
Tool results:
→ result (ok): (Bash completed with no output)
Tools used:
Bash:ls /Users/USER/workspace/doctolib/upfront/packages/ 2>/dev/null | head -20
Tool results:
→ result (ok): core create-upfront demo-app dev metrics tools
Tools used:
Bash:cat /private/tmp/claude-501/-Users-clertonra-workspace-doctolib-treatment-plan/4a60c61a-52a8-4582-9de5-258d84f5e6ef/tasks/bm0trxstk.output 2>/dev/null
Tool results:
→ result (ok): (Bash completed with no output)
Tools used:
Bash:find /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type -name "*.tgz" -path "*tpf-national-health-records-ui*" 2>/dev/null | head -3
Tools used:
Bash:find /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type -name "yarn.lock" -o -name "package-lock.json" 2>/dev/null | head -3
Tool results:
→ result (ok): (Bash completed with no output)
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/package-lock.json
Tools used:
Bash:grep -A5 '"@doctolib/tpf-national-health-records-ui"' /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/package-lock.json | head -20
Tool results:
→ result (ok): "@doctolib/tpf-national-health-records-ui": "^14.1.0", "@doctolib/tpf-pdf-utils": "^1.5.1", "@doctolib/tpf-rich-texts": "^4.1.5", "@doctolib/tpf-rich-texts-form": "^5.2.10", "@doctolib/tpf-rich-texts-fulfillment": "^4.4.6", "@doctolib/treatments": "^3.23.2", -- "@doctolib/tpf-national-health-records-ui": "^14.1.0", "@doctolib/variation_management": "^1.0.0", "@tanstack/react-query-v5": "npm:@tanstack/react-query@^5.51.15", " …(truncated, 362 more chars)
Tools used:
Bash:grep -n '"@doctolib/tpf-national-health-records-ui"' /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/package-lock.json | head -5
Tool results:
→ result (ok): 110: "@doctolib/tpf-national-health-records-ui": "^14.1.0", 64601: "@doctolib/tpf-national-health-records-ui": "^14.1.0", 68334: "@doctolib/tpf-national-health-records-ui": "^14.0.0",
Tools used:
Bash:grep -n '"node_modules/@doctolib/tpf-national-health-records-ui"' /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/package-lock.json | head -5
Tool results:
→ result (ok): 10526: "node_modules/@doctolib/tpf-national-health-records-ui": {
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/package-lock.json(10526–10536)
Tool results:
→ result (ok): 10526 "node_modules/@doctolib/tpf-national-health-records-ui": { 10527 "version": "14.1.0", 10528 "resolved": "https://doctolib-580698825394.d.codeartifact.eu-west-1.amazonaws.com/npm/meta/@doctolib/tpf-national-health-records-ui/-/tpf-national-health-records-ui-14.1.0.tgz", 10529 "integrity": "sha512-EdHRkbts4GmETgcsOCb/jl6Iq8O4cAYFbMVXAl6z+Z/l1mjh2giFj9m5EbEztGOY8iT8Cg9yPEOW8S5ziIhPdg==", 10530 "license": "Doctolib", 10531 "dependencies": { 10532 "@doc …(truncated, 193 more chars)
The package is published to a private registry. Let me check the installed node_modules for type definitions.
Tools used:
Bash:find /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/node_modules/@doctolib/tpf-national-health-records-ui -name "*.d.ts" 2>/dev/null | xargs gr …(truncated, 84 more chars)
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/node_modules/@doctolib/tpf-national-health-records-ui/dist/index.d.ts /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/node_modules/@doctolib/tpf-national-health-records-ui/dist/business/factories/columns/createNhrProcedureDateColumn.d.ts /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/node_modules/ …(truncated, 102 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/node_modules/@doctolib/tpf-national-health-records-ui/dist/business/factories/columns/createNhrProcedureDateColumn.d.ts
Tool results:
→ result (ok): 1 import type { NhrDocument } from '@doctolib/tpf-national-health-records'; 2 import type { ColumnConfig } from '../../../types.js'; 3 export type NhrProcedureDateColumnOptions = { 4 / Translated column header */ 5 header: string; 6 / 7 * Extracts the ISO date string for the procedure date from the document. 8 * Returns undefined when the procedure date is absent. 9 / 10 getDate: (doc: NhrDocument) => string | null | undefined; 11 }; 12 /* 13 * Feature-based …(truncated, 420 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/node_modules/@doctolib/tpf-national-health-records-ui/dist/business/factories/columns/createNhrShareDateColumn.d.ts
Tool results:
→ result (ok): 1 import type { NhrDocument } from '@doctolib/tpf-national-health-records'; 2 import type { ColumnConfig } from '../../../types.js'; 3 export type NhrShareDateColumnOptions = { 4 / Translated column header */ 5 header: string; 6 / 7 * Extracts the ISO date string for the share date from the document. 8 * Returns undefined when the share date is absent. 9 / 10 getDate: (doc: NhrDocument) => string | null | undefined; 11 }; 12 /* 13 * Feature-based factory: pr …(truncated, 384 more chars)
Good. Now let me also check the test files and the DmpNhrAdapter test to evaluate parseHl7DateToIso test coverage.
Tools used:
Bash:cd /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type && git diff origin/master...HEAD -- 'packages/@doctolib/national-health-records/src/business/ …(truncated, 128 more chars)
Tool results:
→ result (ok): diff --git a/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.test.ts b/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.test.ts index c053604527bf..e90706214ee0 100644 --- a/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.test.ts +++ b/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.test.ts @@ -49,6 +49,7 @@ const dmpSearchResult: DmpSearchResult = { classCode: '11488 …(truncated, 9565 more chars)
Now let me look at the existing adapter source to understand the full context of parseHl7DateToIso and whether it belongs in src/business/helpers/ versus being a private file-level function.
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.ts
Tool results:
→ result (ok): 1 import type { 2 DmpApi, 3 DmpAuthor, 4 DmpDocument, 5 DmpDocumentContent, 6 SearchProps, 7 SearchResult as DmpSearchResult, 8 } from '@doctolib/dmp' 9 import { DOCUMENT_STATUS, DOCUMENT_VISIBILITY, getPatientInsForDMP } from '@doctolib/dmp' 10 import { isUnstructured } from '@doctolib/cda/types/UnstructuredBody' 11 import { isStructured } from '@doctolib/cda/types/StructuredBody' 12 import type { Patient } from 'monolith_DEPRECATED/types/doctor/api/Patient' 13 import type { 14 Nh …(truncated, 7356 more chars)
Tools used:
Bash:ls /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/business/
Tool results:
→ result (ok): adapters builders mappers
Tools used:
Bash:ls /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/business/mappers/ /Users/USER/workspace/d …(truncated, 153 more chars)
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/business/builders/: actionsBuilder.ts
/Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/business/mappers/: toNhrPatientInformation.ts
Tools used:
Bash:ls /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/ 2>/dev/null
Tool results:
→ result (ok): business hooks index.ts locales mocks variants
Tools used:
Bash:ls /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/business/adapters/ 2>/dev/null
Tool results:
→ result (ok): DmpNhrAdapter.test.ts DmpNhrAdapter.ts
Tools used:
Bash:grep -rn "parseHl7DateToIso\|parseHl7\|hl7Date" /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/ …(truncated, 11 more chars)
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.ts:90:function parseHl7DateToIso(hl7Date: string | undefined): string | undefined { /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.ts:91: if (!hl7Date) return undefined /Users/USER/workspace …(truncated, 2166 more chars)
Tools used:
Bash:ls /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/business/adapters/ 2>/dev/null
Tool results:
→ result (ok): DmpNhrAdapter.test.ts DmpNhrAdapter.ts
Tools used:
Bash:grep -rn "parseHl7\|hl7\|HL7" /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/ 2>/dev/null | grep …(truncated, 18 more chars)
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.test.ts:162: describe('HL7 date conversion in toNhrDocument', () => { /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.test.ts:165: it('converts HL7-8 creationDate (YYYYMMDD) to ISO date st …(truncated, 4034 more chars)
Now let me check the dmpDocumentHelpers.ts file fully to review the comment lines added, and also check whether src/helpers/ exists.
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/variants/dmp/mappers/dmpDocumentHelpers.ts
Tool results:
→ result (ok): 1 import type { NhrDocument } from '@doctolib/tpf-national-health-records'
2 import type { NhrVisibilityEntry } from '@doctolib/tpf-national-health-records-ui'
3 import { DOCUMENT_STATUS, DOCUMENT_VISIBILITY } from '@doctolib/dmp'
4
5 const CLASS_CODE_SYSTEM = 'dmp:classCode'
6 const TYPE_CODE_SYSTEM = 'dmp:typeCode'
7 const PATIENT_CODE = '90' // EX_3.1-1040: class code for patient-authored documents
8
9 // Prefer the LOINC/JDV_J07 typeCode when present; fall back to the JDV_J06 classCode.
10
…(truncated, 2775 more chars)
Tools used:
Bash:ls /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/ 2>/dev/null && find /Users/USER/workspac …(truncated, 161 more chars)
Tool results:
→ result (ok): business hooks index.ts locales mocks variants
I now have a complete picture of all changes. Let me compile the review.
Architecture Review: PR #240556 — fhir-2216_fix-nhr-date-columns-and-document-type
Reviewed files:
- /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/business/adapters/DmpNhrAdapter.ts
- /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/variants/dmp/mappers/dmpDocumentHelpers.ts
- /Users/USER/workspace/doctolib/worktrees/doctolib/fhir-2216_fix-nhr-date-columns-and-document-type/packages/@doctolib/national-health-records/src/mocks/nhrMockedDocuments.ts
Critical Issues (must fix)
None. There are no architecture violations that break separation of concerns or established patterns.
Warnings (should fix)
1. parseHl7DateToIso is tested indirectly through the adapter integration — it has no direct unit tests for edge cases.
The function lives in DmpNhrAdapter.ts as a module-private function, which is the correct scoping decision for something used only inside that adapter. However, the current test suite covers only the happy paths exercised via toNhrDocument (8-char YYYYMMDD, 14-char YYYYMMDDHHMMSS, empty string). There is no test for a malformed input of, say, 6 or 10 characters — the function returns undefined silently in those cases, which is the intended contract, but the contract is not asserted.
The test at line 207 of DmpNhrAdapter.test.ts does cover "unrecognised HL7 date length", but it routes through the full adapter pipeline rather than testing the function in isolation. This is acceptable given the private scope, but the tradeoff is that any future change to the function's boundary conditions will require reading through adapter-level plumbing to find what changed.
This is not a blocker, but if parseHl7DateToIso is ever needed by a second adapter (e.g. a future FhirNhrAdapter), it must be promoted to src/business/mappers/ or a dedicated src/business/helpers/hl7.ts file before being reused. Do not inline-copy it. The architecture rules prohibit subdirectories inside src/helpers/, so a flat file name like hl7DateUtils.ts would be the right placement if that moment arrives.
2. The getTypeCode comment in dmpDocumentHelpers.ts encodes a JIRA ticket number as change provenance.
// Both are stored in classification.codes since FHIR-2216.
Comments that say "since [ticket]" are a code smell in this architecture. The git history already provides that provenance. The comment should describe the invariant, not when it was introduced. Replace with a statement of the rule:
// classification.codes may contain both a classCode (JDV_J06) and a typeCode (JDV_J07/LOINC).
// typeCode is preferred for display when available; classCode is the authoritative fallback.
The same applies to the isPatientAuthored comment: "Splitting CLASS_CODE_SYSTEM / TYPE_CODE_SYSTEM ensures this check is unaffected" describes an implementation side-effect of the current PR's refactor. It is not a stable invariant. Remove the second sentence and keep only the regulatory reference:
// classCode '90' identifies patient-authored documents per EX_3.1-1040.
// This check must never be satisfied by a typeCode entry.
Suggestions (consider improving)
1. CLASS_CODE_SYSTEM / TYPE_CODE_SYSTEM split — pattern is correct, consider aligning the naming.
The split from a single DMP_SYSTEM constant to two named constants is architecturally sound. The naming is clear and the constants are correctly module-private (not exported). No action required beyond the comment cleanup noted above.
2. getProcedureDate / getShareDate return type change is fully compatible.
The callers pass these functions as getDate to createNhrProcedureDateColumn and createNhrShareDateColumn. Both column factories declare getDate: (doc: NhrDocument) => string | null | undefined. The new return type string | undefined is assignable to that parameter type. TypeScript will not complain, and the column cell components already handle the absent-date case. No action required.
3. Mock data overhaul in nhrMockedDocuments.ts — status values are now numeric strings.
The change from human-readable labels ('ACTIVE', 'MASKED', 'ARCHIVED', 'OBSOLETE') to numeric string codes ('1', '2', '4') aligns the mocks with the real DMP API contract, which is the stated purpose. The batch comments have been updated to reflect the new scenario intent. This is correct.
One observation: the mock file previously contained 'MASKED|ACTIVE' as a composite status string for a few documents. Those entries have been collapsed to single numeric codes. If the splitStatus callback in columnsFactory.tsx (line 64: splitStatus: (status) => [status]) was ever intended to handle pipe-delimited composite strings, that is now no longer tested by the mocks. Verify that the splitStatus simplification is intentional and that no production data sends composite status values through the DMP API before the adapter normalizes them.