Project: workspace-doctolib · Branch: HEAD · Mode:  · Model: claude-sonnet-4-6

Stats: 1 user messages, 2 tool calls, tools used: Bash.

Conversation

Turn 1 — User

Fetch the diff and changed files of GitHub PR https://github.com/doctolib/doctolib/pull/238923 using the gh CLI tool. I need to know exactly which files were changed and what the changes were (particularly any version bumps for @doctolib/tpf-national-health-records-ui). Run: gh pr diff 238923 --repo doctolib/doctolib and also gh pr view 238923 --repo doctolib/doctolib --json title,body,files. Report the full list of changed files and the diff content. Do not modify any files.

Turn 1 — Assistant

I'll fetch the PR diff and changed files for you.

Tools used:

- Bash: gh pr view 238923 --repo doctolib/doctolib --json title,body,files 2>&1

Tools used:

- Bash: gh pr diff 238923 --repo doctolib/doctolib 2>&1

Tool results:

  → result (ok): {"body":"## Summary\n\n- Bumps @doctolib/tpf-national-health-records-ui from ^11.0.0 / ^10.1.0 to ^12.1.0 in all files that pin this dependency\n- The new major version 12.1.0 was released in https://github.com/doctolib/treatment-plan/pull/2855 and contains the NhrDocumentListTable pagination feature\n- Previous semver ranges (^11.x, ^10.x) are blocked from resolving 12.x by npm semver rules\n\n## Files updated\n\n- package.json (root)\n- packages/@doctolib/national-health-rec
…(truncated, 1163 more chars)

Tool results:

  → result (ok): diff --git a/package-lock.json b/package-lock.json
index 1af14e47ebba7..05f9606c038de 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -107,7 +107,7 @@
         "@doctolib/tpf-muster-barcode-generator": "^1.16.2",
         "@doctolib/tpf-muster-forms": "^6.4.7",
         "@doctolib/tpf-national-health-records": "^5.0.0",
-        "@doctolib/tpf-national-health-records-ui": "^11.0.0",
+        "@doctolib/tpf-national-health-records-ui": "^12.1.0",
         "@doctolib/tpf-pdf-utils": "^1.
…(truncated, 8177 more chars)

Here is the complete report for PR #238923:

Title: chore(fhir-2091): bump @doctolib/tpf-national-health-records-ui to ^12.1.0

---

Changed Files (7 total)

| File | Additions | Deletions |
|---|---|---|
| package-lock.json | 7 | 13 |
| package.json | 1 | 1 |
| packages/@doctolib/monolith-mfr-tools/src/doctor/mfr-dependencies.json | 1 | 1 |
| packages/@doctolib/national-health-records/package.json | 1 | 1 |
| packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.ts | 2 | 2 |
| packages/@doctolib/national-health-records/src/variants/dmp/mappers/dmpDocumentHelpers.ts | 5 | 5 |
| packages/@doctolib/shared_patient_file_and_appointment_page_components/package.json | 1 | 1 |

---

Version Bump Summary for @doctolib/tpf-national-health-records-ui

- package.json (root): ^11.0.0 → ^12.1.0
- packages/@doctolib/national-health-records/package.json: ^11.0.0 → ^12.1.0
- packages/@doctolib/shared_patient_file_and_appointment_page_components/package.json: ^10.1.0 → ^12.1.0
- packages/@doctolib/monolith-mfr-tools/src/doctor/mfr-dependencies.json: ^11.0.0 → ^12.1.0
- package-lock.json: resolved version 11.0.0 → 12.1.0, and the nested deduped @doctolib/tpf-national-health-records sub-dep inside that package moved from 5.0.0 to 5.1.0 (removing the separate nested node_modules entry since the root version now satisfies).

---

Code Changes (beyond version bumps)

Two TypeScript files in packages/@doctolib/national-health-records/src/variants/dmp/ were updated to align with the new API in ^12.1.0:

mappers/dmpDocumentHelpers.ts
- Added import: import type { NhrVisibilityEntry } from '@doctolib/tpf-national-health-records-ui'
- getVisibility(doc): string was renamed to getVisibilityEntries(doc): NhrVisibilityEntry[]
- Return type changed from a plain string to an array of { label: string, isVisible: boolean } objects
- Logic was also corrected: the isObsolete check now takes priority (previously the "Hidden from professionals and patient" branch was unreachable due to a logic bug)

factories/columnsFactory.ts
- Import updated: getVisibility → getVisibilityEntries
- Usage in createNhrVisibilityColumn: getVisibility → getVisibilityEntries

---

PR Summary (from body)

The bump is necessary because 12.1.0 (released in treatment-plan PR #2855) contains the NhrDocumentListTable pagination feature, and npm semver ranges ^11.x / ^10.x cannot resolve 12.x`.