Project: workspace-doctolib · Branch: HEAD · Mode: ` · **Model:**claude-sonnet-4-6`
Stats: 1 user messages, 28 tool calls, tools used: Bash, Read.
Conversation
Turn 1 — User
Analyze test coverage for PR #3086 in doctolib/treatment-plan. Branch: fhir-2223_fix-column-widths-truncation.
Key changes:
1. getTextContent(node: ReactNode): string — NEW helper — test file: NhrDocumentListTableBody.helpers.test.ts (8 tests covering string, number, React element, array, nested, null/undefined/boolean)
2. <Table fixedLayout={true}> — test: asserts dl-table-layout-fixed class present
3. <TableHeadCell initialWidth={col.width}> — test: asserts style={{ width: '25%' }} on column header
4. Truncation wrapper <div className="truncate" title={getTextContent(...)}> — test: asserts getByTitle('SOPK test results') is in document
5. width?: string added to ColumnConfig type
Run gh pr diff 3086 --repo doctolib/treatment-plan to see the exact diff. Evaluate whether tests adequately cover the new functionality and edge cases.
Turn 1 — Assistant
I'll analyze the PR by fetching the diff and examining the test files.
Tools used:
Bash:gh pr diff 3086 --repo doctolib/treatment-plan 2>&1
Tools used:
Bash:gh pr view 3086 --repo doctolib/treatment-plan 2>&1
Tool results:
→ result (ok): diff --git a/packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTable.test.tsx b/packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTable.test.tsx index 4e7eb52c1d..8cfd9e4228 100644 --- a/packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTable.test.tsx +++ b/packages/tpf-national-health-records-ui/src/components/N …(truncated, 10881 more chars)
Tool results:
→ result (ok): title: fix(FHIR-2223): fix proportional column widths with text truncation in NhrDocumentListTable
state: DRAFT
author: clertonraf (Clerton Araujo)
labels:
assignees:
reviewers:
projects:
milestone:
number: 3086
url: https://github.com/doctolib/treatment-plan/pull/3086
additions: 97
deletions: 3
auto-merge: disabled
--
Summary
- Adds
width?: stringtoColumnConfigtype so consumers can set proportional column widths - Sets
fixedLayout={true}onTableto apply `table-layout: fixe …(truncated, 1140 more chars)
Now let me examine the existing test files and source files more closely to understand the full test context.
Tools used:
Bash:find /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation 2>/dev/null -type f | head -5 || echo "worktree not found"
Tools used:
Bash:gh pr files 3086 --repo doctolib/treatment-plan 2>&1
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/nx.json /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/vitest-shared.config.ts /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/tailwind.config.js /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/mkdocs.yml /Users/USER/workspace/doctolib/worktrees/treatment-plan/fh …(truncated, 51 more chars)
Tool results:
→ result (ERROR): Exit code 1 unknown command "files" for "gh pr"
Usage: gh pr <command> [flags]
Available commands: checkout checks close comment create diff edit list lock merge ready reopen revert review status unlock update-branch view
The worktree exists locally. Let me read the relevant source and test files directly.
Tools used:
Bash:find /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src -type f | sort
Tool results:
→ result (ok): <persisted-output> Output too large (31KB). Full output saved to: /Users/USER/.claude/projects/-Users-clertonra-workspace-doctolib/407de113-0dc8-46d8-b9d8-d23e896adad4/tool-results/bzjfylwt9.txt
Preview (first 2KB): /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/tests/index.test.ts /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-hea …(truncated, 1497 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTableBody/NhrDocumentListTableBody.helpers.ts
Tool results:
→ result (ok): 1 import { isValidElement } from 'react'
2 import type { ReactNode } from 'react'
3
4 export function getTextContent(node: ReactNode): string {
5 if (typeof node === 'string' || typeof node === 'number') return String(node)
6 if (Array.isArray(node)) return node.map(getTextContent).join('')
7 if (isValidElement(node)) return getTextContent((node.props as { children?: ReactNode }).children)
8 return ''
9 }
10
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTableBody/NhrDocumentListTableBody.helpers.test.ts
Tool results:
→ result (ok): 1 import { createElement } from 'react'
2 import { describe, expect, it } from 'vitest'
3
4 import { getTextContent } from './NhrDocumentListTableBody.helpers'
5
6 describe('getTextContent', () => {
7 it('should return a string value unchanged', () => {
8 expect(getTextContent('hello')).toBe('hello')
9 })
10
11 it('should convert a number to string', () => {
12 expect(getTextContent(42)).toBe('42')
13 })
14
15 it('should extract text from a React element with a string child
…(truncated, 884 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTableBody/NhrDocumentListTableBody.tsx
Tool results:
→ result (ok): 1 import { TableBody } from '@doctolib/design-system/TableBody'
2 import { TableCell } from '@doctolib/design-system/TableCell'
3 import { TableRow } from '@doctolib/design-system/TableRow'
4 import { TableSelectCell } from '@doctolib/design-system/TableSelectCell'
5 import type { NhrDocument } from '@doctolib/tpf-national-health-records'
6
7 import type { ActionConfig, ColumnConfig } from '../../../../types'
8 import { ActionButton } from './ActionButton'
9 import { getTextContent } from './Nh
…(truncated, 1320 more chars)
Now let me read the test files for the table head and body, and also check the mock data used:
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTableHead/NhrDocumentListTableHead.test.tsx
Tool results:
→ result (ok): 1 import { setup } from '@doctolib/test-helpers'
2 import { screen } from '@testing-library/react'
3 import { describe, expect, it } from 'vitest'
4
5 import { mockColumns } from '../../../../test-helpers'
6 import type { ColumnConfig } from '../../../../types'
7 import { NhrDocumentListTableHead } from './NhrDocumentListTableHead'
8
9 describe('NhrDocumentListTableHead', () => {
10 it('should render all column header labels from the column config', () => {
11 setup(
12 <table>
13
…(truncated, 1544 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTableBody/NhrDocumentListTableBody.test.tsx
Tool results:
→ result (ok): 1 import type { DesignSystemIconComponent } from '@doctolib/design-system-icons'
2 import { setup } from '@doctolib/test-helpers'
3 import { screen, waitFor } from '@testing-library/react'
4 import { describe, expect, it, vi } from 'vitest'
5
6 import { createMoreActionsAction } from '../../../../business/factories/actions/createMoreActionsAction'
7 import { mockColumns, mockRows } from '../../../../test-helpers'
8 import { nhrDocumentFixtureBuilder } from '../../../../test-helpers/fixtures/nhr
…(truncated, 6312 more chars)
Tools used:
Bash:find /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/test-helpers -type f | sort
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/test-helpers/fixtures/createFixtureBuilder.test.ts /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/test-helpers/fixtures/createFixtureBuilder.ts /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-r …(truncated, 1332 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTable.test.tsx
Tool results:
→ result (ok): 1 import { setup } from '@doctolib/test-helpers'
2 import { screen } from '@testing-library/react'
3 import { describe, expect, it } from 'vitest'
4
5 import { mockColumns, mockRows } from '../../../test-helpers'
6 import { NhrDocumentListTable } from './NhrDocumentListTable'
7
8 const defaultPaginationProps = {
9 currentPage: 1,
10 total: 0,
11 onPageChange: () => {},
12 }
13
14 describe('NhrDocumentListTable', () => {
15 it('should render a table', () => {
16 setup(<NhrDocumentL
…(truncated, 2315 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/test-helpers/fixtures/mockData.ts
Tool results:
→ result (ok): 1 import { nhrDocumentFixtureBuilder } from './nhrDocumentFixtureBuilder'
2 import { nhrPatientInfoFixtureBuilder } from './nhrPatientInfoFixtureBuilder'
3
4 export { nhrDocumentListColumns as mockColumns } from '../../components/NhrEntryPoint/nhrDocumentListColumns'
5
6 export const mockPatientInfo = nhrPatientInfoFixtureBuilder()
7
8 export const mockRows = [
9 nhrDocumentFixtureBuilder(),
10 nhrDocumentFixtureBuilder({
11 id: '2',
12 title: 'MRI Brain scan',
13 creationDate
…(truncated, 652 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/test-helpers/index.ts
Tool results:
→ result (ok): 1 export * from './fixtures' 2
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/test-helpers/fixtures/nhrDocumentFixtureBuilder.ts
Tool results:
→ result (ok): 1 import type { NhrDocument } from '@doctolib/tpf-national-health-records'
2
3 import { createFixtureBuilder } from './createFixtureBuilder'
4
5 export const nhrDocumentFixtureBuilder = createFixtureBuilder<NhrDocument>({
6 id: '1',
7 title: 'SOPK test results',
8 creationDate: '2025-01-13',
9 submissionDate: '2025-01-18',
10 status: 'Current',
11 visibility: 'Visible to all',
12 format: 'application/pdf',
13 authors: [{ id: 'doc1', firstName: 'Mario', lastName: 'Casas', role:
…(truncated, 120 more chars)
Tools used:
Bash:find /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src -name "nhrDocumentListColumns*" | sort
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/components/NhrEntryPoint/nhrDocumentListColumns.tsx
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/components/NhrEntryPoint/nhrDocumentListColumns.tsx
Tool results:
→ result (ok): 1 import type { ColumnConfig } from '../../types'
2
3 export const nhrDocumentListColumns: ColumnConfig[] = [
4 {
5 key: 'category',
6 header: 'Document category',
7 sortable: false,
8 render: (doc) => doc.classification?.codes[0]?.code ?? '-',
9 },
10 {
11 key: 'title',
12 header: 'Document name',
13 sortable: true,
14 sortAccessor: (doc) => doc.title,
15 render: (doc) => doc.title,
16 },
17 {
18 key: 'procedureDate',
19 header: 'Procedure
…(truncated, 894 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/types.ts
Tool results:
→ result (ok): 1 import type { DesignSystemIconComponent } from '@doctolib/design-system-icons'
2 import type { NhrDocument, NhrResultStatus } from '@doctolib/tpf-national-health-records'
3 import type { ReactNode } from 'react'
4
5 export type NhrPatientInfo = {
6 fullName: string
7 gender: 'male' | 'female' | 'other'
8 birthDate: string
9 age: number
10 }
11
12 export type ColumnConfig = {
13 key: string
14 header: string
15 sortable: boolean
16 /** Only required when sortable: true. Return
…(truncated, 3831 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTableHead/NhrDocumentListTableHead.tsx
Tool results:
→ result (ok): 1 import { TableHead } from '@doctolib/design-system/TableHead'
2 import { TableHeadCell } from '@doctolib/design-system/TableHeadCell'
3 import { TableHeadSelectAllCell } from '@doctolib/design-system/TableHeadSelectAllCell'
4 import { TableRow } from '@doctolib/design-system/TableRow'
5
6 import type { ColumnConfig } from '../../../../types'
7
8 export type NhrDocumentListTableHeadProps = {
9 columns: ColumnConfig[]
10 }
11
12 export const NhrDocumentListTableHead = ({ columns }: NhrDocum
…(truncated, 372 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTable.tsx
Tool results:
→ result (ok): 1 import { PAGE_SIZE } from '#utils/nhrPaginationHelpers'
2 import { Pagination } from '@doctolib/design-system/Pagination'
3 import { Table } from '@doctolib/design-system/Table'
4 import type { NhrDocument } from '@doctolib/tpf-national-health-records'
5
6 import type { ActionConfig, ColumnConfig } from '../../../types'
7 import { NhrDocumentListTableBody } from './NhrDocumentListTableBody/NhrDocumentListTableBody'
8 import { NhrDocumentListTableHead } from './NhrDocumentListTableHead/NhrDocu
…(truncated, 993 more chars)
I now have a complete picture of the diff, the implementation, and all the tests. Let me synthesize my analysis.
Tools used:
Bash:grep -r "col.render(row)" /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src --include="*.tsx" --include="* …(truncated, 12 more chars)
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTableBody/NhrDocumentListTableBody.tsx:33: <div className='truncate' title={getTextContent(col.render(row))}> /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal …(truncated, 112 more chars)
Tools used:
Bash:grep -rn "truncate" /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src --include="*.tsx" --include="*.ts" 2 …(truncated, 3 more chars)
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTableBody/NhrDocumentListTableBody.tsx:33: <div className='truncate' title={getTextContent(col.render(row))}>
Tools used:
Bash:# Check if any column render function returns a React element (not just strings) to understand if getTextContent handles real-world render() outputs …
Tool results:
→ result (ok): render: (doc) => doc.classification?.codes[0]?.code ?? '-', }, { key: 'title', header: 'Document name', sortable: true, -- render: (doc) => doc.title, }, { key: 'procedureDate', header: 'Procedure date', sortable: true, -- render: (doc) => doc.serviceInformation?.startDate ?? '-', }, { key: 'submissionDate', header: 'Share date', sortable: true, -- render: (doc) => doc.submissionDate ?? '-', }, { key: 'author', header: 'Shar …(truncated, 347 more chars)
Tools used:
Bash:# Check for any column factory files that may create columns with React element renders (the consuming doctolib repo adds actual widths) …
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/business/factories/columns/createNhrDocumentCategoryColumn.test.tsx /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/business/factories/columns/createNhrDocumentCategoryColumn.tsx /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncat …(truncated, 2286 more chars)
Tools used:
Bash:grep -h "render" /Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/business/factories/columns/createNhrDoc …(truncated, 426 more chars)
Tool results:
→ result (ok): render: (doc: NhrDocument) => ( render: (doc: NhrDocument) => <NhrVisibilityCell entries={options.getVisibilityEntries(doc)} />, * When absent, doc.status is rendered as a single badge with the raw string as the label (no statusMap lookup). * Pill config rendered when doc.status is undefined or empty, render: (doc: NhrDocument) => (
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/business/factories/columns/createNhrDocumentCategoryColumn.tsx
Tool results:
→ result (ok): 1 import type { NhrDocument } from '@doctolib/tpf-national-health-records'
2
3 import { NhrDocumentCategoryCell } from '../../../components/NhrDocumentList/NhrDocumentCategoryCell/NhrDocumentCategoryCell'
4 import type { IconMap } from '../../../components/NhrDocumentList/NhrDocumentCategoryCell/NhrDocumentCategoryCell'
5 import type { ColumnConfig } from '../../../types'
6
7 export type NhrDocumentCategoryColumnOptions = {
8 / Translated column header */
9 header: string
10 / Extrac
…(truncated, 1071 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/business/factories/columns/createNhrStatusColumn.tsx
Tool results:
→ result (ok): 1 import type { PillColor } from '@doctolib/design-system/Pill'
2 import type { NhrDocument } from '@doctolib/tpf-national-health-records'
3
4 import { NhrStatusCell } from '../../../components/NhrDocumentList/NhrStatusCell'
5 import type { ColumnConfig } from '../../../types'
6
7 / Pill config for a single recognized status token */
8 export type NhrDocumentStatusConfig = {
9 label: string
10 color?: PillColor
11 }
12
13 export type NhrStatusColumnOptions = {
14 / Translated column
…(truncated, 1764 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/worktrees/treatment-plan/fhir-2223_fix-column-widths-truncation/packages/tpf-national-health-records-ui/src/business/factories/columns/createNhrVisibilityColumn.tsx
Tool results:
→ result (ok): 1 import type { NhrDocument } from '@doctolib/tpf-national-health-records'
2
3 import { NhrVisibilityCell } from '../../../components/NhrDocumentList/NhrVisibilityCell'
4 import type { ColumnConfig, NhrVisibilityEntry } from '../../../types'
5
6 export type NhrVisibilityColumnOptions = {
7 / Translated column header */
8 header: string
9 / Decodes document visibility into badge entries /
10 getVisibilityEntries: (doc: NhrDocument) => NhrVisibilityEntry[]
11 }
12
13 /*
14 * Feat
…(truncated, 474 more chars)
I now have all the information I need. Let me compile the final analysis.
Summary
The PR adds four pieces of new functionality: a getTextContent pure helper, fixedLayout on the Table, initialWidth on TableHeadCell, and a truncation wrapper in TableBody. Each change has at least one test. Overall, test coverage is adequate for a presentational/UI change of this scope, and the tests follow the project's RTL/Vitest conventions. There are no critical uncovered paths, but a few meaningful gaps exist.
Critical Gaps
None rated 9-10
There are no security-critical, data-loss, or system-failure-level gaps. All new production branches are exercised.
Important Improvements
1. No test verifies that a column without width does NOT receive an inline style (rating: 6)
The new test in /packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTableHead/NhrDocumentListTableHead.test.tsx covers the "width present" branch. The negative branch — col.width is undefined, so initialWidth receives undefined and no style attribute is emitted — is not tested. If someone accidentally changed initialWidth={col.width} to initialWidth={col.width ?? '10%'}, no existing test would fail.
A concrete regression it prevents: a future change that adds a default fallback width would silently break all columns that are supposed to auto-size, and no test would catch it.
Suggested assertion to add to the existing head test file (alongside the existing mockColumns tests, since none of those columns carry a width value):
expect(screen.getByRole('columnheader', { name: 'Document name' })).not.toHaveStyle('width')
2. The truncation tooltip test relies on a single hardcoded value tied to the fixture default (rating: 6)
The test at line 102-110 of /packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTableBody/NhrDocumentListTableBody.test.tsx asserts getByTitle('SOPK test results'). This passes only because nhrDocumentFixtureBuilder() defaults to title: 'SOPK test results' and the render function for the title column returns doc.title directly.
The truncation wrapper is applied to every column in every row, but the test only confirms one specific title value. Two meaningful gaps:
- A React-element-returning column (like those produced by createNhrDocumentCategoryColumn, createNhrStatusColumn, createNhrVisibilityColumn) will produce an empty string tooltip. There is no test covering the case where a render function returns a React element, confirming that getTextContent is actually invoked and the tooltip is populated correctly. If getTextContent were removed from the title prop, the Pill/badge columns would silently show empty tooltips and this test would not catch it.
- The test says "includes a title tooltip" but actually only verifies one specific text value exists somewhere in the document. It does not verify it is on the wrapping div for that column.
Adding one test with a mock column whose render returns a React element (e.g., createElement('span', null, 'Category label')) and asserting getByTitle('Category label') would cover the real-world usage path where getTextContent does actual recursive work in production.
3. col.render(row) is called twice per cell in production (rating: 5)
In /packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTableBody/NhrDocumentListTableBody.tsx lines 33-34:
<div className='truncate' title={getTextContent(col.render(row))}>
{col.render(row)}
</div>
col.render(row) is invoked twice per cell. For pure string-returning columns this is harmless, but for render functions that trigger side effects or construct expensive sub-trees, this doubles the work. No test currently would catch a regression if the double-call introduced a visible bug (for instance, a render function that returns a component with an internal useEffect). This is worth a brief comment or a memoization of the result into a local variable in the production code, but the test gap here is lower priority — the current column factories are all pure.
Test Quality Issues
The dl-table-layout-fixed class assertion is acceptable but slightly implementation-coupled
The test in NhrDocumentListTable.test.tsx line 65 uses document.querySelector('.dl-table-layout-fixed'). The project's own testing rules note this pattern requires a justification comment, which is present ("Testing that Oxygen's fixedLayout prop applies the CSS class"). The justification is valid here: the intent of fixedLayout={true} is specifically that this CSS class is applied, so verifying the class is the most direct way to confirm the Oxygen component honored the prop. The test is correctly scoped and the comment satisfies the project's CSS-selector exception policy.
The getTextContent test correctly uses createElement instead of JSX
The unit test file /packages/tpf-national-health-records-ui/src/components/NhrDocumentListModal/NhrDocumentListTable/NhrDocumentListTableBody/NhrDocumentListTableBody.helpers.test.ts uses .ts extension (not .tsx) and imports createElement directly, which is idiomatic for a non-JSX file. This is correct and avoids an unnecessary .tsx conversion.
Positive Observations
- All 8
getTextContentcases cover the complete TypeScript union ofReactNode(string,number,ReactElement,ReactNode[],null,undefined,boolean). The recursive case is covered. This is thorough for a pure helper. - The
widthtest inNhrDocumentListTableHead.test.tsxcreates its own isolatedColumnConfigfixture rather than mutating sharedmockColumns, keeping the test hermetic. - The tooltip test uses
getByTitle(a semantic query), not a CSS selector, which will survive DOM restructuring. - The
fixedLayouttest is appropriately placed at the integration level (NhrDocumentListTable) rather than duplicated in both child components, since the prop is set at that layer. - The PR correctly avoids testing that
width?: stringappears in the TypeScript type definition — that is a type-system concern verified bytsc, not a runtime test.