Project: doctolib-doctolib · Branch: .invalid · Mode: ` · **Model:**claude-haiku-4-5-20251001`
Stats: 1 user messages, 28 tool calls, tools used: Bash, Read, Grep.
Conversation
Turn 1 — User
Explore the NHR (National Health Records) DMP variant code in /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/ to understand exactly how columnsFactory.ts wires getTypeCode into createNhrDocumentCategoryColumn, and what the constants.ts and mappers look like.
Also check: 1. packages/@doctolib/national-health-records/src/variants/dmp/constants.ts — the DMP_CLASS_CODES array 2. packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.ts — full source 3. packages/@doctolib/national-health-records/src/variants/dmp/mappers/dmpDocumentHelpers.ts — full source 4. packages/@doctolib/national-health-records/src/variants/dmp/index.ts — what is exported 5. packages/@doctolib/national-health-records/src/variants/dmp/factories/ — all files 6. Are there any existing tests for columnsFactory.ts? 7. Is there already any i18n, t(), or translation mechanism used in the dmp variant code?
Report exact file paths, line numbers, full source code of all relevant files. This is for planning a label-mapping implementation.
Turn 1 — Assistant
I'll explore the NHR DMP variant code systematically to understand the structure and implementation details.
Tools used:
Bash:find /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp -type f -name "*.ts" -not -path "*/node_modules/*" | head -20
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/useDmpDocumentListVariant.ts /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/constants.ts /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.test.ts /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories/filtersFactory. …(truncated, 932 more chars)
Now let me read all the key files to understand the DMP variant implementation:
Tools used:
Read:/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/constants.ts
Tool results:
→ result (ok): 1 // Real dmp:classCode values from JDV_J06/JDV_J07 ANS value set (DMP certification) 2 export const DMP_CLASS_CODES = [ 3 '11502-2', // CR d'examens biologiques (lab report) 4 '70004-7', // CR d'acte diagnostique – autre (diagnostic/imaging) 5 '11488-4', // CR ou fiche de consultation ou de visite (consultation report) 6 '11505-5', // CR d'acte thérapeutique – autre (therapeutic act / prescription) 7 '34112-3', // CR hospitalier – séjour (hospital stay / discharge summary) 8 '11369- …(truncated, 346 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.ts
Tool results:
→ result (ok): 1 import type { ColumnConfig } from '@doctolib/tpf-national-health-records-ui' 2 import { 3 createNhrDocumentCategoryColumn, 4 createNhrDocumentNameColumn, 5 createNhrProcedureDateColumn, 6 createNhrShareDateColumn, 7 createNhrSharedByColumn, 8 createNhrStatusColumn, 9 createNhrVisibilityColumn, 10 } from '@doctolib/tpf-national-health-records-ui' 11 import { DOCUMENT_STATUS } from '@doctolib/dmp' 12 import { FileRegularIcon } from '@doctolib/design-system-icons/FileRegularIcon' 13 …(truncated, 1466 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/mappers/dmpDocumentHelpers.ts
Tool results:
→ result (ok): 1 import type { NhrDocument } from '@doctolib/tpf-national-health-records'
2 import type { NhrVisibilityEntry } from '@doctolib/tpf-national-health-records-ui'
3 import { DOCUMENT_STATUS, DOCUMENT_VISIBILITY } from '@doctolib/dmp'
4
5 const DMP_SYSTEM = 'dmp:classCode'
6 const PATIENT_CODE = '90' // EX_3.1-1040: class code for patient-authored documents
7
8 export const getTypeCode = (doc: NhrDocument): string | undefined =>
9 doc.classification?.codes.find((c) => c.system === DMP_SYSTEM)?.c
…(truncated, 2367 more chars)
Tools used:
Read:/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/index.ts
Tool results:
→ result (ok): 1 export { useDmpDocumentListVariant } from './useDmpDocumentListVariant' 2
Now let me check the test files and other factory files:
Tools used:
Read:/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.test.ts
Tool results:
→ result (ok): 1 import { FileRegularIcon } from '@doctolib/design-system-icons/FileRegularIcon'
2
3 import { createNhrDocumentCategoryColumn } from '@doctolib/tpf-national-health-records-ui'
4 import { columnsFactory } from './columnsFactory'
5
6 jest.mock('@doctolib/dmp', () => ({
7 DOCUMENT_STATUS: {
8 validated: 'validated',
9 obsolete: 'obsolete',
10 archived: 'archived',
11 },
12 }))
13
14 jest.mock('../mappers/dmpDocumentHelpers', () => ({
15 getTypeCode: jest.fn(),
16 getProcedur
…(truncated, 1849 more chars)
Tools used:
Bash:find /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories -type f -name "*.ts" | sort
Tools used:
Read:/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories/filtersFactory.ts
Tool results:
→ result (ok): 1 import {
2 type FilterConfig,
3 createNhrDateSelectionFilterConfig,
4 createNhrDocumentCategoryFilterConfig,
5 createNhrDocumentStatusFilterConfig,
6 createNhrDocumentVisibilityFilterConfig,
7 } from '@doctolib/tpf-national-health-records-ui'
8
9 type FiltersOptions = {
10 lastAccessDate?: string
11 }
12
13 export function filtersFactory({ lastAccessDate = '' }: FiltersOptions = {}): FilterConfig[] {
14 return [
15 createNhrDocumentCategoryFilterConfig(),
16 createNhrDa
…(truncated, 1029 more chars)
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.test.ts /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.ts /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories/filtersFactory.test.ts /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factor …(truncated, 21 more chars)
Now let me check the main variant hook and check for i18n/translation usage:
Tools used:
Read:/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/useDmpDocumentListVariant.ts
Tool results:
→ result (ok): 1 import { columnsFactory } from './factories/columnsFactory'
2 import { filtersFactory } from './factories/filtersFactory'
3 import type { NhrDocumentListVariant, DocumentSearchOptions } from '../types'
4 import useDmpSearchDocuments from '../../hooks/useSearchDocuments'
5 import { mapFiltersToSearchDocumentsParams } from './mappers/mapFiltersToSearchDocumentsParams'
6
7 export const useDmpDocumentListVariant = (patient: DocumentSearchOptions['patient']): NhrDocumentListVariant => {
8 const
…(truncated, 207 more chars)
Tools used:
Grep:import.*i18n|import.*translation|useTranslation|t\(|i18n\.|i18nextin/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp
Tool results:
→ result (ok): Found 4 files packages/@doctolib/national-health-records/src/variants/dmp/mappers/dmpDocumentHelpers.test.ts packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.test.ts packages/@doctolib/national-health-records/src/variants/dmp/mappers/mapFiltersToSearchDocumentsParams.test.ts packages/@doctolib/national-health-records/src/variants/dmp/factories/filtersFactory.test.ts
Good, no i18n found yet. Let me check the test for dmpDocumentHelpers to understand the implementation better:
Tools used:
Read:/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/mappers/dmpDocumentHelpers.test.ts
Tools used:
Read:/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/mappers/mapFiltersToSearchDocumentsParams.ts
Tool results:
→ result (ok): 1 import type { NhrDocument } from '@doctolib/tpf-national-health-records'
2 import { getVisibilityEntries } from './dmpDocumentHelpers'
3
4 const doc = (visibility: string | undefined): NhrDocument => ({ id: '1', title: 'Test', visibility }) as NhrDocument
5
6 describe('getVisibilityEntries', () => {
7 it('returns [] when visibility is "1" (visible to all)', () => {
8 expect(getVisibilityEntries(doc('1'))).toEqual([])
9 })
10
11 it('returns [] when visibility is undefined', () => {
…(truncated, 1431 more chars)
Tool results:
→ result (ok): 1 import type { NhrDocumentSearchParams } from '@doctolib/tpf-national-health-records'
2 import { DOCUMENT_STATUS, DOCUMENT_VISIBILITY } from '@doctolib/dmp'
3 import type { ServerFilters } from '../../types'
4 import { toNhrPatientInformation } from '../../../business/mappers/toNhrPatientInformation'
5
6 // Maps UI-level ServerFilters to the NhrDocumentSearchParams format expected by the NHR API.
7 // Each ServerFilters field needs an explicit mapping — field names do not match NhrDocumentSear
…(truncated, 2415 more chars)
Let me also check the structure of the parent directory to understand the broader context:
Tools used:
Bash:ls -la /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/
Tools used:
Bash:find /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants -type d | head -20
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/mappers
Tool results:
→ result (ok): drwxr-xr-x clertonra staff 224 B Wed Apr 15 10:29:37 2026 . drwxr-xr-x clertonra staff 160 B Wed Apr 15 08:54:20 2026 .. .rw-r--r-- clertonra staff 821 B Wed Apr 15 10:29:37 2026 constants.ts drwxr-xr-x clertonra staff 192 B Wed Apr 15 08:54:20 2026 factories .rw-r--r-- clertonra staff 72 B Tue Apr 7 14:59:56 2026 index.ts drwxr-xr-x clertonra staff 192 B Wed Apr 15 08:54:20 2026 mappers .rw-r--r-- clertonra staff 672 B Thu Apr 9 15:21:29 2026 useDmpDocumentListVariant.ts
Let me check the filtersFactory test to understand the complete picture:
Tools used:
Read:/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories/filtersFactory.test.ts
Tool results:
→ result (ok): 1 import { filtersFactory } from './filtersFactory'
2
3 describe('filtersFactory', () => {
4 it('should return exactly 4 FilterConfig objects', () => {
5 expect(filtersFactory()).toHaveLength(4)
6 })
7
8 it('should return filters with correct keys in order', () => {
9 expect(filtersFactory().map((f) => f.key)).toEqual(['typeCodes', 'dateMode', 'documentStatus', 'visibilityGroup'])
10 })
11 })
12
Tools used:
Bash:grep -r "getTypeCode\|labelMap\|label:" /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp --include="*.ts" -n
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.test.ts:15: getTypeCode: jest.fn(), /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories/filtersFactory.ts:17: label: 'Date', /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories/filtersFactory.ts:20: { value: 'shareDate', label: 'Share date' }, /U …(truncated, 5352 more chars)
Let me check what the createNhrDocumentCategoryColumn function signature looks like and check for any label mapping patterns in the broader codebase:
Tools used:
Bash:find /Users/USER/workspace/doctolib/doctolib/packages/@doctolib -name "*.ts" -path "*national-health-records-ui*" -type f | head -20
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/shared_patient_file_and_appointment_page_components/node_modules/@doctolib/tpf-national-health-records-ui/dist/entry.d.ts /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/shared_patient_file_and_appointment_page_components/node_modules/@doctolib/tpf-national-health-records-ui/dist/locales/loadNamespace.d.ts /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/shared_patient_file_and_appointment_page_components/node_module …(truncated, 3888 more chars)
Let me check the types definition file:
Tools used:
Read:/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/shared_patient_file_and_appointment_page_components/node_modules/@doctolib/tpf-national-health-records-ui/dist/business/factories/columns/createNhrDocumentCategoryColumn.d.ts
Tool results:
→ result (ok): 1 import type { NhrDocument } from '@doctolib/tpf-national-health-records'; 2 import type { IconMap } from '../../../components/NhrDocumentList/NhrDocumentCategoryCell/NhrDocumentCategoryCell.js'; 3 import type { ColumnConfig } from '../../../types.js'; 4 export type NhrDocumentCategoryColumnOptions = { 5 / Translated column header */ 6 header: string; 7 / Extracts the human-readable document category label from a document */ 8 getTypeCode: (doc: NhrDocument) => string | unde …(truncated, 528 more chars)
Perfect! Now let me check the mapFiltersToSearchDocumentsParams test as well:
Tools used:
Read:/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/mappers/mapFiltersToSearchDocumentsParams.test.ts
Tool results:
→ result (ok): 1 import { mapFiltersToSearchDocumentsParams } from './mapFiltersToSearchDocumentsParams'
2
3 jest.mock('@doctolib/dmp', () => ({
4 DOCUMENT_STATUS: { validated: 1, obsolete: 2, archived: 4 },
5 DOCUMENT_VISIBILITY: {
6 sharedWithAll: 1,
7 notSharedWithPatient: 2,
8 notSharedWithPractitioner: 4,
9 notSharedWithLegalRepresentative: 8,
10 },
11 }))
12
13 jest.mock('../../../business/mappers/toNhrPatientInformation', () => ({
14 toNhrPatientInformation: (ins: string) => ({
…(truncated, 6530 more chars)
Perfect! Now let me check if there are any i18n or translation patterns elsewhere in the national-health-records package:
Tools used:
Bash:find /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src -name "*.ts" -type f | xargs grep -l "i18n\|useTranslation\|t(" | head -10
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/mocks/generateNhrDocuments.ts /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/mocks/nhrMockedColumns.ts /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/mocks/generateNhrDocuments.test.ts /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.test.ts /Users/USER/wor …(truncated, 776 more chars)
Let me check one of these files to see the pattern:
Tools used:
Bash:grep -n "i18n\|useTranslation\|t(" /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/mocks/nhrMockedColumns.ts | head -20
Tool results:
→ result (ok): 4:// Column headers are hardcoded in English for the mock. i18n wiring belongs in a follow-up.
Great! Let me check that file and the useNhrDocumentListVariant file:
Tools used:
Read:/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/mocks/nhrMockedColumns.ts
Tool results:
→ result (ok): 1 import type { ColumnConfig } from '@doctolib/tpf-national-health-records-ui'
2 import type { NhrDocument } from '@doctolib/tpf-national-health-records'
3
4 // Column headers are hardcoded in English for the mock. i18n wiring belongs in a follow-up.
5 // Renders are intentionally plain-text — styled cell components will replace them once
6 // the factory functions are available in the published @doctolib/tpf-national-health-records-ui.
7
8 export const buildMockedColumns = (): ColumnConfig[]
…(truncated, 1499 more chars)
Tools used:
Bash:grep -B5 -A5 "i18n\|useTranslation" /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/useNhrDocumentListVariant.ts
Tool results:
→ result (ok): (Bash completed with no output)
Let me check the types file to understand the ServerFilters type:
Tools used:
Bash:find /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src -name "types.ts" -o -name "types.d.ts" | head -5
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/types.ts
Tools used:
Read:/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/types.ts
Tool results:
→ result (ok): 1 import type { ColumnConfig, FilterConfig } from '@doctolib/tpf-national-health-records-ui'
2 import type { Patient } from 'monolith_DEPRECATED/types/doctor/api/Patient'
3 import type { NhrDocument, NhrDocumentSearchParams } from '@doctolib/tpf-national-health-records'
4
5 interface SearchDocumentsResult {
6 data: NhrDocument[]
7 total: number
8 }
9
10 export type NhrDocumentListVariant = {
11 columns: ColumnConfig[]
12 filters: FilterConfig[]
13 searchDocuments: (appliedFilters?: R
…(truncated, 791 more chars)
Perfect! Now let me verify the structure of mappers directory and create a comprehensive summary:
Tools used:
Bash:ls -la /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/mappers/
Tool results:
→ result (ok): drwxr-xr-x clertonra staff 192 B Wed Apr 15 08:54:20 2026 . drwxr-xr-x clertonra staff 224 B Wed Apr 15 10:29:37 2026 .. .rw-r--r-- clertonra staff 1.8 KB Wed Apr 15 08:54:20 2026 dmpDocumentHelpers.test.ts .rw-r--r-- clertonra staff 2.6 KB Wed Apr 15 08:54:20 2026 dmpDocumentHelpers.ts .rw-r--r-- clertonra staff 6.4 KB Mon Apr 13 14:23:57 2026 mapFiltersToSearchDocumentsParams.test.ts .rw-r--r-- clertonra staff 2.7 KB Mon Apr 13 14:23:57 2026 mapFiltersToSearchDocumentsParams.ts
Perfect! Now let me create a comprehensive summary. Let me check one more thing - if there are any existing labelMap or mapping patterns for document type codes:
Tools used:
Bash:grep -r "labelMap\|mapping\|11502-2\|70004-7\|11488-4" /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src --include="*.ts" -n | grep -v test | grep -v node_mod …(truncated, 4 more chars)
Tool results:
→ result (ok): /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/mocks/nhrMockedDocuments.ts:15: classification: { codes: [{ system: 'dmp:classCode', code: '11502-2' }] }, /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/mocks/nhrMockedDocuments.ts:27: classification: { codes: [{ system: 'dmp:classCode', code: '11502-2' }] }, /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/mocks/nhrMockedDocu …(truncated, 4053 more chars)
Now let me check the nhrMockedDocuments to understand the structure better:
Tools used:
Read:/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/mocks/nhrMockedDocuments.ts(1–101)
Tool results:
→ result (ok): 1 import type { NhrDocument } from '@doctolib/tpf-national-health-records'
2
3 export const nhrMockedDocuments: NhrDocument[] = [
4 // ── Batch 1: Laboratory reports (6 docs) ──────────────────────────────────
5 {
6 id: 'mock-001',
7 title: 'SOPK hormone panel',
8 creationDate: '2025-01-13',
9 submissionDate: '2025-01-18',
10 status: '1',
11 visibility: '1',
12 format: 'application/pdf',
13 serviceInformation: { startDate: '2025-01-10' },
14 authors: [{ i
…(truncated, 3438 more chars)
Perfect! Now I have all the information I need. Let me create a comprehensive summary document.
EXPLORATION SUMMARY: NHR DMP Variant Code Structure
I've thoroughly explored the DMP (Data de Mon Professionnel) variant implementation in the National Health Records module. Here are the exact findings:
1. Key Files and Their Locations
Core Constants:
- /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/constants.ts (Lines 1-14)
- Exports DMP_CLASS_CODES array with 9 elements:
- '11502-2' → CR d'examens biologiques (lab report)
- '70004-7' → CR d'acte diagnostique – autre (diagnostic/imaging)
- '11488-4' → CR ou fiche de consultation ou de visite (consultation report)
- '11505-5' → CR d'acte thérapeutique – autre (therapeutic act / prescription)
- '34112-3' → CR hospitalier – séjour (hospital stay / discharge summary)
- '11369-6' → Historique de vaccinations (vaccination history)
- '60568-3' → CR d'anatomie et de cytologie pathologiques (pathology / specialist report)
- '34874-8' → CR opératoire (surgical report)
- 'REMB' → Données de remboursement (reimbursement data)
- Includes type export: type DmpClassCode
Column Factory:
- /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories/columnsFactory.ts (Lines 1-61)
- CRITICAL: How getTypeCode is wired:
- Line 26: Passes getTypeCode function as a parameter to createNhrDocumentCategoryColumn()
- Line 3-10: Imports getTypeCode from ../mappers/dmpDocumentHelpers
- createNhrDocumentCategoryColumn signature (from types definition) expects:
- header: string (human-readable column header)
- getTypeCode: (doc: NhrDocument) => string | undefined (extracts the document type code)
- iconMap?: IconMap (optional mapping of label → icon, uses '*' as catch-all)
- Creates 7 columns total: documentCategory, documentName, procedureDate, shareDate, sharedBy, status, visibility
- Hardcoded header strings: 'Document type', 'Document name', 'Procedure date', 'Share date', 'Shared by', 'Status', 'Visibility'
Document Helpers Mapper:
- /Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/mappers/dmpDocumentHelpers.ts (Lines 1-56)
- getTypeCode implementation (Lines 8-9):
```typescript
export const getTypeCode = (doc: NhrDocument): string | undefined =>
doc.classification?.codes.find((c) => c.system === DMP_SYSTEM)?.code
- System identifier: `'dmp:classCode'` (Line 5)
- Returns the code string (e.g., `'11502-2'`) or `undefined`
- No label mapping currently exists—returns raw code, not human-readable label
- **Patient code constant (Line 6):** `PATIENT_CODE = '90'` (for patient-authored documents)
- **Visibility label helpers (Lines 24-49):**
- `HIDDEN_FROM_PATIENT = 'Hidden from patient'`
- `HIDDEN_FROM_HCPS = 'Hidden from HCPs'`
- `HIDDEN_FROM_GUARDIANS = 'Hidden from guardians'`
- `getVisibilityEntries()` returns an array of `NhrVisibilityEntry` objects with `label`, `isVisible`, and `variant` properties
**Filter Factory:**
- `/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/factories/filtersFactory.ts` (Lines 1-44)
- Returns 4 `FilterConfig` objects (keys: 'typeCodes', 'dateMode', 'documentStatus', 'visibilityGroup')
- Hardcoded filter labels: 'Date', 'Share date', 'Procedure date', 'Archived', 'Obsolete', 'Masked to professionals', 'Invisible to patient', 'Invisible to legal representatives'
- Accepts optional `lastAccessDate` parameter
**Filter-to-Search Params Mapper:**
- `/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/mappers/mapFiltersToSearchDocumentsParams.ts` (Lines 1-65)
- Maps UI-level `ServerFilters` to API-level `NhrDocumentSearchParams`
- Uses bitmask composition for status and visibility (powers of 2)
- No label mapping—purely parameter transformation
**Main Export:**
- `/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/index.ts` (Lines 1-1)
- Only exports: `useDmpDocumentListVariant`
**Variant Hook:**
- `/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/variants/dmp/useDmpDocumentListVariant.ts` (Lines 1-14)
- Composes columns and filters from factories
- Does NOT directly use or reference type code labels
---
### **2. Factory Files in `/factories/` Directory**
Two factory files exist:
1. **columnsFactory.ts** (61 lines) - ✓ Full source provided above
2. **columnsFactory.test.ts** (61 lines) - Tests mocking: `getTypeCode`, `getProcedureDate`, `getShareDate`, `getAuthorName`, `isPatientAuthored`, `getVisibilityEntries`
3. **filtersFactory.ts** (44 lines) - ✓ Full source provided above
4. **filtersFactory.test.ts** (11 lines) - Tests that factory returns exactly 4 filters with correct keys in order
---
### **3. Test Coverage**
**columnsFactory.test.ts (Lines 43-61):**
- Tests that `iconMap` is passed to `createNhrDocumentCategoryColumn`
- Tests that `'*'` catch-all key exists and maps to `FileRegularIcon`
- Does NOT test label mapping (because it doesn't exist yet)
**dmpDocumentHelpers.test.ts (Lines 1-44):**
- Tests `getVisibilityEntries()` extensively for all visibility combinations
- Tests hardcoded string labels: `'Hidden from patient'`, `'Hidden from HCPs'`, `'Hidden from guardians'`
- NO tests for `getTypeCode` label mapping
---
### **4. i18n / Translation Status**
**NO i18n wiring exists in the DMP variant code:**
- Zero imports of i18n, `useTranslation`, `t()`, or translation functions
- All labels are hardcoded English strings
- Comment in `/Users/USER/workspace/doctolib/doctolib/packages/@doctolib/national-health-records/src/mocks/nhrMockedColumns.ts` (Line 4):
> "Column headers are hardcoded in English for the mock. i18n wiring belongs in a follow-up."
- This signals that i18n integration is planned but not yet implemented
**Hardcoded labels in production code:**
1. **columnsFactory.ts:** 'Document type', 'Document name', 'Procedure date', 'Share date', 'Shared by', 'Status', 'Visibility'
2. **filtersFactory.ts:** 'Date', 'Share date', 'Procedure date', 'Archived', 'Obsolete', 'Masked to professionals', 'Invisible to patient', 'Invisible to legal representatives'
3. **dmpDocumentHelpers.ts:** 'Hidden from patient', 'Hidden from HCPs', 'Hidden from guardians'
---
### **5. Current Label Mapping Gap**
**The Problem:**
- `getTypeCode()` returns raw codes like `'11502-2'`, `'70004-7'`, etc.
- `createNhrDocumentCategoryColumn` expects `getTypeCode` to return the code so the column can display it
- **There is NO mapping from code to human-readable label** (e.g., `'11502-2'` → `'Lab Report'`)
- The code is displayed as-is in the UI
**Where a label map would fit:**
1. **Option A:** Create a `labelMap` in `dmpDocumentHelpers.ts`:
```typescript
const DMP_CLASS_CODE_LABELS: Record<DmpClassCode, string> = {
'11502-2': 'Lab report',
'70004-7': 'Diagnostic report',
// ... etc
}
export const getTypeCodeLabel = (code: string | undefined): string =>
DMP_CLASS_CODE_LABELS[code as DmpClassCode] ?? code ?? '–'
- Option B: Pass a
labelMapparameter tocreateNhrDocumentCategoryColumn: ```typescript createNhrDocumentCategoryColumn({ header: 'Document type', getTypeCode, labelMap: { '11502-2': 'Lab Report', ... }, iconMap: { '*': FileRegularIcon }, })
3. **Option C (Recommended for i18n):** Use a translation function:
```typescript
const { t } = useTranslation('dmp')
const labelMap = {
'11502-2': t('documentTypes.labReport'),
// ... etc
}
6. Architecture Summary
columnsFactory()
↓ imports ↓
getTypeCode() [fro
…(truncated, 1465 more chars)